From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="RkrrZy4e" Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1759E127 for ; Tue, 5 Dec 2023 04:52:55 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ca0f21e48cso17992891fa.2 for ; Tue, 05 Dec 2023 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1701780773; x=1702385573; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/6khWfPZUJLhn3k3Km8qMBNnWS1yZtR1UUMcUgVXgbE=; b=RkrrZy4eHDBcJhQOuMWlKJgQkGX8wyiPArC4re/LHLGQAQGIB3z/ag2tdSHQG0GqqP PLALcv5E3RCU7jC61zirPrbfbUeU8trpx1HXpU8Ub4gknVdlumt3XX28AO0ZbV0zwqSa tmae09CRYKt+dH1alWiua3dmCCxit4f8ZPP0IggTTeQNnDWo52WGMqpvBN+NXODCVYn5 qojEA03dAA+/RvvgaxhROBfQe/ptbZjvz2H7Hs6pe9vvjz7h7EvBnLYp9V4w5KZb/qRy sN/EK3qu6jnRtsWuaxsW34HX3LWgFnt+Ndz/LJ+uZA8s5ge5w3DzNTZR1pc+3nhRIwTx V0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701780773; x=1702385573; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/6khWfPZUJLhn3k3Km8qMBNnWS1yZtR1UUMcUgVXgbE=; b=RJonQrCzQ5jjqrlB5NU60N1hirN+WSdTxpBr5VQ8otE+AmkR06BwKCQzNIsTMpVmZN +BPhCAvjVXtxO63QjI4BT6eI6m7nW3fjyrkPm3p0CNIqX/AjQuT6mDPfyxIyxndxkGJ7 A/Fjy/PxUnqSSOGbTsVrMAS1QSiLXAqPMIMsASD7/7bjRSs9sIUlqn2uZUpRVIbbMcZ5 G1tng826/9yct24gwfw6ZCTFoHIehnFe1AI+AG1N+yzOGPoz0OmYQfgkYD3808RUZnrL bhkq9t3y+J3YBVS8/eaaEHQLk+TFFQABnDBsxVKDgGNA67i9UDXGqrNhxro8YCjvEGlb rzSw== X-Gm-Message-State: AOJu0YyvF+Ewqfckh6egDz3I4z+X66QMEZN79GvXD1CKwhH7RQ9lHATe o+MOCSvqvidJ5s8DHULTCrcKwQ== X-Google-Smtp-Source: AGHT+IEaTv9JPYFtY5cztOH3hevOJnMBWMWWpGD6f//fYLRlQTcv4U9qGajlw8lAyC7RdC8q8wP2zQ== X-Received: by 2002:a05:651c:cc:b0:2c9:f0e8:bb5f with SMTP id 12-20020a05651c00cc00b002c9f0e8bb5fmr2841059ljr.40.1701780773336; Tue, 05 Dec 2023 04:52:53 -0800 (PST) Received: from ?IPv6:2804:30c:915:cb00:89a8:6d94:ec55:e0a3? ([2804:30c:915:cb00:89a8:6d94:ec55:e0a3]) by smtp.gmail.com with ESMTPSA id e8-20020a17090ab38800b002801ca4fad2sm4479134pjr.10.2023.12.05.04.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:52:52 -0800 (PST) Message-ID: <12a9ec1bc84dc6d4b461e5c780ba7d3c3aa91740.camel@suse.com> Subject: Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall From: mpdesouza@suse.com To: Shuah Khan , Marcos Paulo de Souza Cc: Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org Date: Tue, 05 Dec 2023 09:52:46 -0300 In-Reply-To: <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org> References: <20231031-send-lp-kselftests-v3-0-2b1655c2605f@suse.com> <20231031-send-lp-kselftests-v3-3-2b1655c2605f@suse.com> <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote: > On 12/1/23 06:13, Marcos Paulo de Souza wrote: > > On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: >=20 > > >=20 > > > Missing module name? Is there a reason to not name this module? > >=20 > > Can you please elaborate? This new module use the same MODULE_ > > macros used by > > the current livepatch selftests. What do you mean by module name? > >=20 >=20 > Pre-commit checpatch script spdx check complained about the module > name. > Please run it to see the message. I've ran checkpatch on all the tree patches, and so far it complained about MAINTANERS file needing to be updated (since we removed lib/livepatch and it's mentioned on MAINTAINERS file): $ ./scripts/checkpatch.pl 000*.patch =20 ----------------------------------------------------------- 0001-kselftests-lib.mk-Add-TEST_GEN_MODS_DIR-variable.patch ----------------------------------------------------------- total: 0 errors, 0 warnings, 68 lines checked 0001-kselftests-lib.mk-Add-TEST_GEN_MODS_DIR-variable.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0002-livepatch-Move-tests-from-lib-livepatch-to-selftests.patch --------------------------------------------------------------- WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #17:=20 debug and rebuild the tests by running make on the selftests/livepatch directory, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #82:=20 rename {lib/livepatch =3D> tools/testing/selftests/livepatch/test_modules}/test_klp_atomic_replace .c (100%) total: 0 errors, 2 warnings, 519 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. 0002-livepatch-Move-tests-from-lib-livepatch-to-selftests.patch has style problems, please review. --------------------------------------------------------------- 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch --------------------------------------------------------------- WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #60:=20 new file mode 100755 total: 0 errors, 1 warnings, 237 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. I couldn't find any mention about "missing module name". Is your script showing more warnings than these ones? Can you please share your output? I'll fix MAINTAINERS file but I'll wait until I understand what's missing in your checkpatch script to resend the patchset. Thanks, Marcos=20 >=20 > thanks, > -- Shuah >=20