From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Denis Pauk <pauk.denis@gmail.com>,
eugene.shalygin@gmail.com, andy.shevchenko@gmail.com,
Ed Brindley <kernel@maidavale.org>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: (asus_wmi_sensors) Support X370 Asus WMI.
Date: Sun, 10 Oct 2021 16:10:43 +0200 [thread overview]
Message-ID: <13b23940-88d9-4c72-a55b-a66e8c8edffb@t-8ch.de> (raw)
In-Reply-To: <7658358e-5ba6-b764-463c-317f5b318707@roeck-us.net>
On 2021-10-10T06:38-0700, Guenter Roeck wrote:
> On 10/10/21 3:20 AM, Thomas Weißschuh wrote:
> > Hi,
> >
> > for WMI drivers the list platform-driver-x86@vger.kernel.org should probably be
> > on CC too.
> > Also all other WMI drivers, even for hwmon stuff are located in
> > drivers/platform/x86 so it may be better to put it there, too.
> >
>
> Not really. If any of those other drivers are pure hwmon drivers, they
> should reside in drivers/hwmon instead. And, yes, that really includes
> the gigabyte-wmi driver. We don't have arbitrary drivers in drivers/pci
> either just because they are drivers for pci devices.
Fair enough.
I suppose it would be too much churn to move gigabyte-wmi to
hwmon now though, correct?
Having the platform-driver-x86 on Cc would still be useful as they can provide
guidance about using the ACPI/WMI/platform APIs.
For example by using the WMI bus as mentioned in my other mail would allow
to completely remove the manually maintained DMI list and instead directly bind
to the WMI GUID for any device that supports this GUID.
(This is possible as this WMI API seems to be self-describing, so all
specific parameters can be discovered by the driver)
Thomas
next prev parent reply other threads:[~2021-10-10 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 9:52 [PATCH v3 0/2] Update ASUS WMI supported boards Denis Pauk
2021-10-10 9:52 ` [PATCH v3 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI Denis Pauk
2021-10-10 9:52 ` [PATCH v3 2/2] hwmon: (asus_wmi_sensors) Support X370 " Denis Pauk
2021-10-10 10:20 ` Thomas Weißschuh
2021-10-10 13:38 ` Guenter Roeck
2021-10-10 14:10 ` Thomas Weißschuh [this message]
2021-10-10 14:56 ` Guenter Roeck
2021-10-10 15:28 ` Thomas Weißschuh
2021-10-10 16:21 ` Guenter Roeck
2021-10-10 13:54 ` [PATCH v3 0/2] Update ASUS WMI supported boards Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13b23940-88d9-4c72-a55b-a66e8c8edffb@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=kernel@maidavale.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pauk.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox