From: Ivan Zaentsev <ivan.zaentsev@wirenboard.ru>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Jonathan Corbet <corbet@lwn.net>,
Akira Shimahara <akira215corp@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Colin Ian King <colin.king@canonical.com>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Evgeny Boger <boger@wirenboard.com>
Subject: Re: [PATCH 2/2] w1: w1_therm: Add support for GXCAS GX20MH01 device.
Date: Wed, 7 Oct 2020 10:32:27 +0300 [thread overview]
Message-ID: <1561045277.20201007103227@wirenboard.ru> (raw)
In-Reply-To: <20201006151915.77d044a4@coco.lan>
Tuesday, October 6, 2020, 4:19:15 PM, Mauro Carvalho Chehab wrote:
>> diff --git a/Documentation/w1/slaves/w1_therm.rst b/Documentation/w1/slaves/w1_therm.rst
>> index f1148181f53e..00376501a5ef 100644
>> --- a/Documentation/w1/slaves/w1_therm.rst
>> +++ b/Documentation/w1/slaves/w1_therm.rst
>>
>> @@ -130,4 +131,12 @@ conversion and temperature reads 85.00 (powerup value) or 127.94 (insufficient
>> power), the driver returns a conversion error. Bit mask ``2`` enables poll for
>> conversion completion (normal power only) by generating read cycles on the bus
>> after conversion starts. In parasite power mode this feature is not available.
>> -Feature bit masks may be combined (OR).
>> +Feature bit masks may be combined (OR). See accompanying sysfs documentation:
>> +:ref:`Documentation/w1/slaves/w1_therm.rst <w1_therm>`
>> +
> As warned by Sphinx, this cross-reference is broken:
> .../Documentation/w1/slaves/w1_therm.rst:125: WARNING:
> undefined label: w1_therm (if the link has no caption the label must precede a section header)
Would this be ok?
"More details in Documentation/ABI/testing/sysfs-driver-w1_therm"
> Not sure what you wanted to point here.
A link to a driver's sysfs interface, but sysfs docs are text
files and seem to not be included in Sphynx Docs.
--
Best regards,
Ivan mailto:ivan.zaentsev@wirenboard.ru
next prev parent reply other threads:[~2020-10-07 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 16:00 [PATCH 1/2] w1: w1_therm: Add sysfs entries to control conversion time and driver features Ivan Zaentsev
2020-09-04 16:00 ` [PATCH 2/2] w1: w1_therm: Add support for GXCAS GX20MH01 device Ivan Zaentsev
2020-10-06 13:19 ` Mauro Carvalho Chehab
2020-10-07 7:32 ` Ivan Zaentsev [this message]
2020-10-07 8:57 ` Mauro Carvalho Chehab
2020-10-07 9:06 ` Greg Kroah-Hartman
2020-10-07 11:05 ` Mauro Carvalho Chehab
2020-10-07 11:43 ` Greg Kroah-Hartman
2020-10-07 11:59 ` Mauro Carvalho Chehab
2020-10-21 16:28 ` Adding ABI to htmldocs - Was: " Mauro Carvalho Chehab
2020-10-21 16:58 ` Greg Kroah-Hartman
2020-10-22 8:19 ` Mauro Carvalho Chehab
2020-10-29 14:28 ` Mauro Carvalho Chehab
2020-11-09 17:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561045277.20201007103227@wirenboard.ru \
--to=ivan.zaentsev@wirenboard.ru \
--cc=akira215corp@gmail.com \
--cc=boger@wirenboard.com \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).