Re: [RFC PATCH v4 01/22] bootconfig: Add Extra Boot Config support

Steven Rostedt
2019-12-09T15:54:07Z

On Mon, 9 Dec 2019 14:50:09 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Hi Randy,
>
> Thank you for your review!
>
> On Sun, 8 Dec 2019 11:34:32 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > Hi,
> >
> > On 12/2/19 2:13 AM, Masami Hiramatsu wrote:
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index 67a602ee17f1..13bb3eac804c 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -1235,6 +1235,17 @@ source "usr/Kconfig"
> > >
> > > endif
> > >
> > > +config BOOT_CONFIG
> > > + bool "Boot config support"
> > > + select LIBXBC
> > > + default y
> >
> > questionable "default y".
> > That needs lots of justification.
>
> OK, I can make it 'n' by default.
>
> I thought that was OK because most of the memories for the
> bootconfig support were released after initialization.
> If user doesn't pass the bootconfig, only the code for
> /proc/bootconfig remains on runtime memory.

As 'n' is usually the default, I will argue this should be 'y'!

This is not some new fancy feature, or device that Linus
complains about "my X is important!". I will say this X *is* important!
This will (I hope) become standard in all kernel configs. One could even
argue that there shouldn't even be a config for this at all (forced
'y'). This would hurt more not to have than to have. I would hate to
try to load special options only to find out that the kernel was
compiled with default configs and this wasn't enabled.

This is extended boot config support that can be useful for most
developers. The only ones that should say 'n' are those that are
working to get a "tiny" kernel at boot up. As Masami said, the memory
is freed after init, thus this should not be an issue for 99.9% of
kernel users.

-- Steve

>
> > > + help
> > > + Extra boot config allows system admin to pass a config file as
> > > + complemental extension of kernel cmdline when boot.
> >
> > when booting.
>