Re: [PATCH v2 3/3] RISC-V: hwprobe: Expose Zba, Zbb, and Zbs

Conor Dooley
2023-05-09T18:34:16Z

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Tue, May 09, 2023 at 11:25:03AM -0700, Evan Green wrote:
> + if (riscv_isa_extension_available(isainfo->isa, ZBA))
> + pair->value |= RISCV_HWPROBE_EXT_ZBA;
> + else
> + missing |= RISCV_HWPROBE_EXT_ZBA;

Part of me wonders if we should just have a macro for this, since it's
just boilerplate w/ the only "variable" being the extension name.

Just a thought, and we'll have plenty more cracks at changing things
here, so:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]