From: Jijie Shao <shaojijie@huawei.com>
To: <chia-yu.chang@nokia-bell-labs.com>, <shenjian15@huawei.com>,
<linux-rdma@vger.kernel.org>, <eperezma@redhat.com>,
<jasowang@redhat.com>, <virtualization@lists.linux.dev>,
<mst@redhat.com>, <xuanzhuo@linux.alibaba.com>,
<pabeni@redhat.com>, <edumazet@google.com>,
<linux-doc@vger.kernel.org>, <corbet@lwn.net>, <horms@kernel.org>,
<dsahern@kernel.org>, <kuniyu@google.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, <dave.taht@gmail.com>,
<jhs@mojatatu.com>, <kuba@kernel.org>,
<stephen@networkplumber.org>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>, <donald.hunter@gmail.com>,
<ast@fiberby.net>, <liuhangbin@gmail.com>, <shuah@kernel.org>,
<linux-kselftest@vger.kernel.org>, <ij@kernel.org>,
<ncardwell@google.com>, <koen.de_schepper@nokia-bell-labs.com>,
<g.white@cablelabs.com>, <ingemar.s.johansson@ericsson.com>,
<mirja.kuehlewind@ericsson.com>, <cheshire@apple.com>,
<rs.ietf@gmx.at>, <Jason_Livingood@comcast.com>,
<vidhi_goel@apple.com>
Cc: <shaojijie@huawei.com>
Subject: Re: [PATCH v5 net-next 2/2] net: hns3: fix GSO_ECN flag setting in the RX path
Date: Thu, 6 Aug 2026 19:47:00 +0800 [thread overview]
Message-ID: <169d0d62-2296-476f-95f9-5916d777090e@huawei.com> (raw)
In-Reply-To: <20260804213510.673084-3-chia-yu.chang@nokia-bell-labs.com>
on 2026/8/5 5:35, chia-yu.chang@nokia-bell-labs.com wrote:
> From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
>
> Currently, the hns3 Rx path sets the SKB_GSO_TCP_ECN flag when a TCP
> segment with the CWR flag set is received. This is incorrect because
> the hns3 hardware GRO resets the IP ToS byte to 0 during packet
> aggregation. Consequently, no valid ECN signals are carreid, meaning
> that it cannot support RFC3168 ECN or Accurate ECN protocols. Setting
> SKB_GSO_TCP_ECN or SKB_GSO_TCP_ACCECN under these conditions misleads
> the upper network stack.
>
> Fix this by removing the incorrect SKB_GSO_TCP_ECN flag assignment
> in hns3_gro_complete().
>
> Fixes: d474d88f88261 ("net: hns3: add hns3_gro_complete for HW GRO process")
One note:
since this patch fixes a bug (incorrect SKB_GSO_TCP_ECN flag set in hns3_gro_complete),
it should target net instead of net-next.
I'm running HW tests on hns3 to verify the fix. Will share results
based on what I observe.
Thanks,
Jijie Shao
prev parent reply other threads:[~2026-08-06 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 21:35 [PATCH v5 net-next 0/2] ECN offload handling series chia-yu.chang
2026-08-04 21:35 ` [PATCH v5 net-next 1/2] net: update comments for SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN chia-yu.chang
2026-08-04 21:35 ` [PATCH v5 net-next 2/2] net: hns3: fix GSO_ECN flag setting in the RX path chia-yu.chang
2026-08-06 11:47 ` Jijie Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169d0d62-2296-476f-95f9-5916d777090e@huawei.com \
--to=shaojijie@huawei.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jasowang@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=mst@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rs.ietf@gmx.at \
--cc=shenjian15@huawei.com \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=virtualization@lists.linux.dev \
--cc=xiyou.wangcong@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox