[PATCH bpf-next] Documentation: Fix spelling mistake.

[PATCH bpf-next] Documentation: Fix spelling mistake.

[Eslam Khafagy]

Fix typo "desination => destination"
in file
Documentation/bpf/standardization/instruction-set.rst

Signed-off-by: Eslam Khafagy <eslam.medhat1993@gmail.com>
---
 Documentation/bpf/standardization/instruction-set.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index fbe975585236..ac950a5bb6ad 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -350,9 +350,9 @@ Underflow and overflow are allowed during arithmetic operations, meaning
 the 64-bit or 32-bit value will wrap. If BPF program execution would
 result in division by zero, the destination register is instead set to zero.
 Otherwise, for ``ALU64``, if execution would result in ``LLONG_MIN``
-dividing -1, the desination register is instead set to ``LLONG_MIN``. For
+dividing -1, the destination register is instead set to ``LLONG_MIN``. For
 ``ALU``, if execution would result in ``INT_MIN`` dividing -1, the
-desination register is instead set to ``INT_MIN``.
+destination register is instead set to ``INT_MIN``.
 
 If execution would result in modulo by zero, for ``ALU64`` the value of
 the destination register is unchanged whereas for ``ALU`` the upper
-- 
2.43.0

RE: [PATCH bpf-next] Documentation: Fix spelling mistake.

[Dave Thaler]

> -----Original Message-----
> From: Eslam Khafagy <eslam.medhat1993@gmail.com>
> Sent: Friday, June 6, 2025 3:05 AM
> To: void@manifault.com; ast@kernel.org
> Cc: linux-doc@vger.kernel.org; skhan@linuxfoundation.org;
bpf@vger.kernel.org;
> Eslam Khafagy <eslam.medhat1993@gmail.com>
> Subject: [PATCH bpf-next] Documentation: Fix spelling mistake.
> 
> Fix typo "desination => destination"
> in file
> Documentation/bpf/standardization/instruction-set.rst
> 
> Signed-off-by: Eslam Khafagy <eslam.medhat1993@gmail.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index fbe975585236..ac950a5bb6ad 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -350,9 +350,9 @@ Underflow and overflow are allowed during arithmetic
> operations, meaning  the 64-bit or 32-bit value will wrap. If BPF program
execution
> would  result in division by zero, the destination register is instead set
to zero.
>  Otherwise, for ``ALU64``, if execution would result in ``LLONG_MIN``
-dividing -1,
> the desination register is instead set to ``LLONG_MIN``. For
> +dividing -1, the destination register is instead set to ``LLONG_MIN``.
> +For
>  ``ALU``, if execution would result in ``INT_MIN`` dividing -1, the
-desination register
> is instead set to ``INT_MIN``.
> +destination register is instead set to ``INT_MIN``.
> 
>  If execution would result in modulo by zero, for ``ALU64`` the value of
the
> destination register is unchanged whereas for ``ALU`` the upper
> --
> 2.43.0

For just the spelling correction:
Acked-by: Dave Thaler <dthaler1968@gmail.com>

However the phrase "dividing -1" is one I find confusing.  E.g.,
"INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse.
Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

Dave

Re: [PATCH bpf-next] Documentation: Fix spelling mistake.

[David Vernet]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Fri, Jun 06, 2025 at 08:17:41AM -0700, Dave Thaler wrote:
> > -----Original Message-----
> > From: Eslam Khafagy <eslam.medhat1993@gmail.com>
> > Sent: Friday, June 6, 2025 3:05 AM
> > To: void@manifault.com; ast@kernel.org
> > Cc: linux-doc@vger.kernel.org; skhan@linuxfoundation.org;
> bpf@vger.kernel.org;
> > Eslam Khafagy <eslam.medhat1993@gmail.com>
> > Subject: [PATCH bpf-next] Documentation: Fix spelling mistake.
> > 
> > Fix typo "desination => destination"
> > in file
> > Documentation/bpf/standardization/instruction-set.rst
> > 
> > Signed-off-by: Eslam Khafagy <eslam.medhat1993@gmail.com>

Acked-by: David Vernet <void@manifault.com>

> However the phrase "dividing -1" is one I find confusing.  E.g.,
> "INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse.
> Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

+1, probably worth fixing in a follow-on diff

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH bpf-next] Documentation: Fix spelling mistake.

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Fri,  6 Jun 2025 13:05:11 +0300 you wrote:
> Fix typo "desination => destination"
> in file
> Documentation/bpf/standardization/instruction-set.rst
> 
> Signed-off-by: Eslam Khafagy <eslam.medhat1993@gmail.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [bpf-next] Documentation: Fix spelling mistake.
    https://git.kernel.org/bpf/bpf-next/c/e41079f53e87

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH bpf-next] Documentation: Fix spelling mistake.

[Eslam Khafagy]

On 6/6/25 18:17, Dave Thaler wrote:
> However the phrase "dividing -1" is one I find confusing.  E.g.,
> "INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse.
> Perhaps "divided by" instead of "dividing" assuming the inverse is meant.
Good catch. you're right.
Since this paragraph is taking about overflow and underflow.
it makes more sense that what is meant is "INT_MIN / -1" as this 
actually will overflow.
I just sent another patch for this.