From: NeilBrown <neilb@ownmail.net>
To: "Chuck Lever" <cel@kernel.org>
Cc: "Jeff Layton" <jlayton@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Chuck Lever" <chuck.lever@oracle.com>,
"Alexander Aring" <alex.aring@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] filelock: add lease_dispose_list() helper
Date: Thu, 04 Dec 2025 09:41:21 +1100 [thread overview]
Message-ID: <176480168199.16766.17148776636684804633@noble.neil.brown.name> (raw)
In-Reply-To: <9a6f7f4b-dc45-4288-a8ee-6dcaabd19eb9@app.fastmail.com>
On Thu, 04 Dec 2025, Chuck Lever wrote:
>
> On Mon, Dec 1, 2025, at 10:08 AM, Jeff Layton wrote:
> > ...and call that from the lease handling code instead of
> > locks_dispose_list(). Remove the lease handling parts from
> > locks_dispose_list().
>
> The actual change here isn't bothering me, but I'm having trouble
> understanding why it's needed. It doesn't appear to be a strict
> functional prerequisite for 2/2.
This was almost exactly my thought too. The commit message should say
*why* the change is being made and this one just left us guessing.
But I *do* like the change and would rather it were kept in the series,
but with a simple addition to the commit message saying that is a
simplification that isn't strictly necessary.
Thanks,
NeilBrown
next prev parent reply other threads:[~2025-12-03 22:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 15:08 [PATCH 0/2] filelock: fix conflict detection with userland file delegations Jeff Layton
2025-12-01 15:08 ` [PATCH 1/2] filelock: add lease_dispose_list() helper Jeff Layton
2025-12-03 18:55 ` Chuck Lever
2025-12-03 19:33 ` Jeff Layton
2025-12-03 19:35 ` Chuck Lever
2025-12-03 22:41 ` NeilBrown [this message]
2025-12-01 15:08 ` [PATCH 2/2] filelock: allow lease_managers to dictate what qualifies as a conflict Jeff Layton
2025-12-03 19:00 ` Chuck Lever
2025-12-03 19:44 ` Jeff Layton
2025-12-01 15:19 ` [PATCH 0/2] filelock: fix conflict detection with userland file delegations Chuck Lever
2025-12-01 15:52 ` Jeff Layton
2025-12-01 16:01 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176480168199.16766.17148776636684804633@noble.neil.brown.name \
--to=neilb@ownmail.net \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=corbet@lwn.net \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).