Re: [PATCH v8 02/10] x86/resctrl: Add SDCIAE feature in the command line options

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Babu,

On 8/5/25 4:30 PM, Babu Moger wrote:
> Add the command line options to enable or disable the new resctrl feature

options -> option?

> L3 Smart Data Cache Injection Allocation Enforcement (SDCIAE).
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

> ---
>  .../admin-guide/kernel-parameters.txt         |  2 +-
>  Documentation/filesystems/resctrl.rst         | 21 ++++++++++---------
>  arch/x86/kernel/cpu/resctrl/core.c            |  2 ++
>  3 files changed, 14 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 0d2ea9a60145..0170c0af03cc 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6089,7 +6089,7 @@
>  	rdt=		[HW,X86,RDT]
>  			Turn on/off individual RDT features. List is:
>  			cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
> -			mba, smba, bmec.
> +			mba, smba, bmec, sdciae.
>  			E.g. to turn on cmt and turn off mba use:
>  				rdt=cmt,!mba
>  
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index c7949dd44f2f..f08699030312 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -17,16 +17,17 @@ AMD refers to this feature as AMD Platform Quality of Service(AMD QoS).
>  This feature is enabled by the CONFIG_X86_CPU_RESCTRL and the x86 /proc/cpuinfo
>  flag bits:
>  
> -===============================================	================================
> -RDT (Resource Director Technology) Allocation	"rdt_a"
> -CAT (Cache Allocation Technology)		"cat_l3", "cat_l2"
> -CDP (Code and Data Prioritization)		"cdp_l3", "cdp_l2"
> -CQM (Cache QoS Monitoring)			"cqm_llc", "cqm_occup_llc"
> -MBM (Memory Bandwidth Monitoring)		"cqm_mbm_total", "cqm_mbm_local"
> -MBA (Memory Bandwidth Allocation)		"mba"
> -SMBA (Slow Memory Bandwidth Allocation)         ""
> -BMEC (Bandwidth Monitoring Event Configuration) ""
> -===============================================	================================
> +=============================================================== ================================
> +RDT (Resource Director Technology) Allocation			"rdt_a"
> +CAT (Cache Allocation Technology)				"cat_l3", "cat_l2"
> +CDP (Code and Data Prioritization)				"cdp_l3", "cdp_l2"
> +CQM (Cache QoS Monitoring)					"cqm_llc", "cqm_occup_llc"
> +MBM (Memory Bandwidth Monitoring)				"cqm_mbm_total", "cqm_mbm_local"
> +MBA (Memory Bandwidth Allocation)				"mba"
> +SMBA (Slow Memory Bandwidth Allocation)         		""

With all these adjustments this looks like an ideal time to fix the missing TABs in the SMBA spacing?

> +BMEC (Bandwidth Monitoring Event Configuration) 		""
> +SDCIAE (Smart Data Cache Injection Allocation Enforcement)	""
> +=============================================================== ================================

Reinette