From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE303E1CE9; Mon, 18 May 2026 08:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779093076; cv=none; b=mNmnzix3gEcbA8m9P8t0JlnIxX+7DdagtZnAKYJqI+6LQ8pm5eovZheP1GCkX1lSGa8N5BLDyzRtS5weSCM9zHfUE+q1J2IcxMJcZOZxdcmI90cqW7wbTZyA5F7WpJSqnpmLy2+6fNRoT5GW8Gp1shBEIAvq3viTtwHqiHUkjPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779093076; c=relaxed/simple; bh=Ci68pCgqcEmwN3C0iekNpb1juOrvZpxc3FlBcuK3m3I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nggz5BCV/YRzdPxF3imoOi+/Sl0C8BeM5sX58MDRIZBkAV5DNaAItJwRFLLPsM4IZlJBE42N8TwLjfn1RdO3mfYAmln9Pxnz26m+YQvqUcDsSLkUf9IejEFpX/mvgxQCb4oPmnZ2pi9gFLZFnQG8rg/2H+HbA2pUHr1Swf29KHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y8TUeMcR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y8TUeMcR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 094D8C2BCB7; Mon, 18 May 2026 08:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779093076; bh=Ci68pCgqcEmwN3C0iekNpb1juOrvZpxc3FlBcuK3m3I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y8TUeMcRB/AChMWDS1FZgRWe/c/OvV6Mi642N+KXi+2b8VbxXrHCiTJ3sDExwrPqp 2gB2TX0PmCQrppps+cRHqA3lKAAH8cWqXcy56jK11y8JiVI8Z/qpfJUKobeGzAtwRo XUrsGix6DcbzWT081r0QnA4LiGcJljuLPPikLEA/pERMS0C74qJbOD8DT7aH8kcoOY JZ6Fm6UymbJI2+OaDNzgH9oGMQLjOfE6SQkyPQO/qVeQgcjD3E5g/ad9MVsQ9J9pMd SZVyENOZG4umosslMGYX/tuEYITv/4NJBMXZbk5YdbGbfdgXA7IY8yMzj60q1uKLhp Eh/S7xgM5Mllw== Message-ID: <1d350564-0127-48c1-8988-54245fdb9b23@kernel.org> Date: Mon, 18 May 2026 10:31:10 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] docs: submitting-patches: Clarify that in English "reviewer" is a person To: "Vlastimil Babka (SUSE)" , Krzysztof Kozlowski , Jonathan Corbet , Shuah Khan , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Guenter Roeck References: <20260516123846.63413-2-krzysztof.kozlowski@oss.qualcomm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/16/26 16:39, Vlastimil Babka (SUSE) wrote: > On 5/16/26 14:38, Krzysztof Kozlowski wrote: >> Common understanding of word "Reviewer" is: a person performing a review >> work [1]. Tools are not persons, thus cannot be reviewers in this term. >> Also tools cannot make statements ("A Reviewed-by tag is a statement of >> opinion"), since making a statement needs some sort of conscious mind. >> >> Our docs already clearly mark that "Reviewed-by" must come from a >> person: >> >> - "By offering my Reviewed-by: tag, I state that:" >> >> Usage of first person "I" and word "state" >> >> - "A Reviewed-by tag is *a statement of opinion* that the patch is an >> appropriate modification of the kernel without any remaining serious" >> >> Only a person can make a statement of opinion. >> >> - "Any interested reviewer (who has done the work) can offer a >> Reviewed-by" >> >> A person can offer a tag thus above does not grant the tool >> permission to offer a tag. >> >> However this is not enough and apparently English is not that precise, >> so let's clarify that only a person can state the "Reviewer's statement >> of oversight". >> >> Link: https://en.wiktionary.org/wiki/reviewer [1] >> Cc: Greg Kroah-Hartman >> Cc: Vlastimil Babka >> Cc: Andrew Morton >> Cc: David Hildenbrand >> Cc: Linus Torvalds >> Signed-off-by: Krzysztof Kozlowski > > I agree with the intent that the tag is for people (whether they use a tool > or not to help them). We also don't put "Tested-by: kernel test robot" or > syzkaller on every commit that they test and find no bugs. Review is also > not just about absence of bugs, but agreeing with the larger design and > whether the change makes sense to do in the first place. I'd assume that SOB/RB/ACK would all be real persons, not tools. For SOB we term it as "known identity". I'd assume that a tool is not an identity ... So maybe we should also talk about "know identity" here? In any case, bots providing RB tags is stupid Acked-by: David Hildenbrand (Arm) -- Cheers, David