From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Simon Horman <horms@kernel.org>, Gur Stavi <gur.stavi@huawei.com>
Cc: andrew+netdev@lunn.ch, christophe.jaillet@wanadoo.fr,
corbet@lwn.net, davem@davemloft.net, edumazet@google.com,
gongfan1@huawei.com, guoxin09@huawei.com, helgaas@kernel.org,
jdamato@fastly.com, kuba@kernel.org, lee@trager.us,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
luosifu@huawei.com, meny.yossefi@huawei.com, mpe@ellerman.id.au,
netdev@vger.kernel.org, pabeni@redhat.com,
przemyslaw.kitszel@intel.com, shenchenyang1@hisilicon.com,
shijing34@huawei.com, sumang@marvell.com, wulike1@huawei.com,
zhoushuai28@huawei.com, zhuyikai1@h-partners.com
Subject: Re: [PATCH net-next v06 5/8] hinic3: TX & RX Queue coalesce interfaces
Date: Wed, 9 Jul 2025 14:20:17 +0100 [thread overview]
Message-ID: <1e1da86d-d544-425d-b1f6-fcc88bc49eed@linux.dev> (raw)
In-Reply-To: <20250709115614.GZ452973@horms.kernel.org>
On 09/07/2025 12:56, Simon Horman wrote:
> On Wed, Jul 09, 2025 at 11:26:20AM +0300, Gur Stavi wrote:
>>> On 27/06/2025 07:12, Fan Gong wrote:
>>>> Add TX RX queue coalesce interfaces initialization.
>>>> It configures the parameters of tx & tx msix coalesce.
>>>>
>>>> Co-developed-by: Xin Guo <guoxin09@huawei.com>
>>>> Signed-off-by: Xin Guo <guoxin09@huawei.com>
>>>> Co-developed-by: Zhu Yikai <zhuyikai1@h-partners.com>
>>>> Signed-off-by: Zhu Yikai <zhuyikai1@h-partners.com>
>>>> Signed-off-by: Fan Gong <gongfan1@huawei.com>
>>>> ---
>>>> .../net/ethernet/huawei/hinic3/hinic3_main.c | 61 +++++++++++++++++--
>>>> .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 10 +++
>>>> 2 files changed, 66 insertions(+), 5 deletions(-)
>>>>
>>>
>>> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>>
>> Procedural question about submissions:
>> Are we allowed (or expected) to copy the "Reviewed-by" above to future
>> submissions as long as we do not modify this specific patch?
>
> Vadim is free to offer his own guidance, as it's his tag.
>
> But in principle tags should be carried forward into future submissions
> unless there is a material change. In this case I think that would
> mean a material change this patch.
>
> But if in doubt, please ask.
> Thanks for doing so.
As Simon said, in general if there are no changes in the patch you can
carry forward Rb tag.
next prev parent reply other threads:[~2025-07-09 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 6:12 [PATCH net-next v06 0/8] net: hinic3: Add a driver for Huawei 3rd gen NIC - management interfaces Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 1/8] hinic3: Async Event Queue interfaces Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 2/8] hinic3: Complete " Fan Gong
2025-07-01 12:42 ` Paolo Abeni
2025-06-27 6:12 ` [PATCH net-next v06 3/8] hinic3: Command Queue framework Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 4/8] hinic3: Command Queue interfaces Fan Gong
2025-07-01 12:56 ` Paolo Abeni
2025-07-03 0:44 ` Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 5/8] hinic3: TX & RX Queue coalesce interfaces Fan Gong
2025-06-28 12:46 ` Vadim Fedorenko
2025-07-09 8:26 ` Gur Stavi
2025-07-09 11:56 ` Simon Horman
2025-07-09 13:20 ` Vadim Fedorenko [this message]
2025-06-27 6:12 ` [PATCH net-next v06 6/8] hinic3: Mailbox framework Fan Gong
2025-06-28 13:03 ` Vadim Fedorenko
2025-07-01 6:51 ` Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 7/8] hinic3: Mailbox management interfaces Fan Gong
2025-06-27 6:12 ` [PATCH net-next v06 8/8] hinic3: Interrupt request configuration Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1da86d-d544-425d-b1f6-fcc88bc49eed@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).