From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 098F115A87C for ; Wed, 25 Sep 2024 08:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727253659; cv=none; b=JbzBBm0ODi3x1BOwSoiIMIs0nV1Aw6iB3jPzWwT3aTcsW67nXgMeg/3137zsoglAwxEtmdqph7bI2jjLnhBOnjn7XUUqhSGzfye5c0fuR7uar91ndehFUthDV9Ss6MICaBdD9dgrrf/uZbk6HBKmPG2oYJFReLIPtGf0BTWiHIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727253659; c=relaxed/simple; bh=jzyeuOdmRqFn80/1joF8rMUBJXOJ48ZG0kA33e5fids=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aZfCFcEk3fcNiH1PFcelnb79xWBqpWynpKBz/EQw1SwoahaoK8uUiz+giketEyZA15Cs9C9vnd1cMtTd6ZcwktgX20vyrDk7HlGcAlUWMhJumvHTz26hqsWxcgGqvBIJHkcOEpFsFKohAbJsUCScyyeiMyG7KG1NArYg/sGTzCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lXZBOhQZ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lXZBOhQZ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cbface8d6so82306375e9.3 for ; Wed, 25 Sep 2024 01:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1727253655; x=1727858455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1gWh62e+9y3kqU90XZJ9SkxqBQCkgI99AUyA38n5F+A=; b=lXZBOhQZN+T9yricYMTA2PDuu5+ojKm5mcBblvECYF+zal58qwIhOiUbnMCMYruptJ bVoqXi3u61bQP/ws+AL337hRn22laDcc9nruOB7aBeiZg4D/x6FNmDs/+krCt8B8jsV2 OQNU7Ki8FUUDRjwnE5mXlBN4CR5j6CcfGoasC7Qx1m7EA0Tw7EkxVSt3lRGTY82uTswl W0El6VlJWOK/oUaxORJoybhDRM4IJXqgLGtfQqDJSqNaXJa2Uk2DUGyrDh9HGn/TN0pY Z//CCAcjaJi6RJXqtLUDp5YPAdRP11j3Ebmf120SCTKc8xak0QxNAwStBGAzaGj1yOI/ KYDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727253655; x=1727858455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1gWh62e+9y3kqU90XZJ9SkxqBQCkgI99AUyA38n5F+A=; b=cwxbPmjHdycZjOPTAnvNgWpisLjPiy3iODR2GeYi9oUwq1oTpIGn64dDhYNLRY6hf4 1YpB8m2nZQ/vfmhXO8Lyl0aXtGtmVlftrTTglkZSy8NQFSajWlXUi/cYEqX6z7KUymx5 DHHGkvz/TaUvUlN3n2DhR6MI47gDYpc2l04tyQo0UgdlR0Z0kS5hYaIrNWYkYbu70x7C JhkP858z4QuGkB/9RmOd98wCrS0xkiL+VeXHMow4bB50wlH/Wzdw2iq/Z5u4oK8lRuTe WPw47jM82hEiOGFU7EcX4MCuSi9bAOz0MaiooAc75iwee1j1gQdCQpgYI7Mie/sTAQZ8 0Naw== X-Forwarded-Encrypted: i=1; AJvYcCXS0QFKKhPKQQBQ+M1VasH/d/7tllrD5zrd/cIIFCNzpbEqVyEnH5hE039ygcPrFi+70polnaRVfUA=@vger.kernel.org X-Gm-Message-State: AOJu0YxDudwGY6I6sXZuGtPLH8Wsul2P7uorPgWdnpq1peqfY2yJvUTT hzSH/mFwqufj4xyp4bZcL+WN0TKcbJm6E9gPcrPbnuXORNKIvDk+Qdu7WENA7aM= X-Google-Smtp-Source: AGHT+IH+9QVv57tkAFLswE82YK+fkKh996SQzxAWIqrqV2XZmJ2sMvCo6rPEjeuCpgizS1gmWqKNFQ== X-Received: by 2002:a05:600c:4451:b0:426:6e9a:7a1e with SMTP id 5b1f17b1804b1-42e96242baemr14438675e9.35.1727253654873; Wed, 25 Sep 2024 01:40:54 -0700 (PDT) Received: from [10.2.5.161] (amontpellier-556-1-151-252.w109-210.abo.wanadoo.fr. [109.210.7.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e96a36287sm11223985e9.29.2024.09.25.01.40.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2024 01:40:54 -0700 (PDT) Message-ID: <1ff1aaa7-7478-4b0c-a1ad-c119a11695ba@baylibre.com> Date: Wed, 25 Sep 2024 10:40:52 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/10] iio: adc: ad7606: Add compatibility to fw_nodes To: David Lechner Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jonathan Corbet , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, aardelean@baylibre.com, jstephan@baylibre.com References: <20240920-ad7606_add_iio_backend_support-v2-0-0e78782ae7d0@baylibre.com> <20240920-ad7606_add_iio_backend_support-v2-7-0e78782ae7d0@baylibre.com> Content-Language: en-US From: Guillaume Stols In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/24/24 17:28, David Lechner wrote: > On Fri, Sep 20, 2024 at 7:33 PM Guillaume Stols wrote: >> On the parallel version, the current implementation is only compatible >> with id tables and won't work with fw_nodes, this commit intends to fix >> it. >> >> Also, chip info is moved in the .h file so to be accessible to all the >> driver files that can set a pointer to the corresponding chip as the >> driver data. > This sounds like two unrelated changes, so maybe we should have two patches? Those changes are closely related to each other, in the sense that we now gather the ad7606_chip_info structure directly from the id or match structure, and not anymore the id which is an index where you can get it as an element. I will update the commit message to highlight it more. > > >> static const struct of_device_id ad7606_of_match[] = { >> - { .compatible = "adi,ad7605-4" }, >> - { .compatible = "adi,ad7606-4" }, >> - { .compatible = "adi,ad7606-6" }, >> - { .compatible = "adi,ad7606-8" }, >> - { .compatible = "adi,ad7606b" }, >> - { .compatible = "adi,ad7616" }, >> + { .compatible = "adi,ad7605-4", &ad7605_4_info }, >> + { .compatible = "adi,ad7606-4", &ad7606_4_info }, >> + { .compatible = "adi,ad7606-6", &ad7606_6_info }, >> + { .compatible = "adi,ad7606-8", &ad7606_8_info }, >> + { .compatible = "adi,ad7606b", &ad7606b_info }, >> + { .compatible = "adi,ad7616", &ad7616_info }, > Since we have .compatible = , we should also have .data = for the chip info. ack