* [PATCH] VFIO: Fix Documentation
[not found] <1524218521-61496-1-git-send-email-zhangshaokun@hisilicon.com>
@ 2018-04-20 10:07 ` dongbo (E)
2018-04-30 18:38 ` Alex Williamson
0 siblings, 1 reply; 6+ messages in thread
From: dongbo (E) @ 2018-04-20 10:07 UTC (permalink / raw)
To: alex.williamson, corbet; +Cc: kvm, linux-doc, linux-kernel@vger.kernel.org
From: Dong Bo <dongbo4@huawei.com>
Signed-off-by: Dong Bo <dongbo4@huawei.com>
---
Documentation/vfio.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
index ef6a511..f1a4d3c 100644
--- a/Documentation/vfio.txt
+++ b/Documentation/vfio.txt
@@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
the driver should call vfio_add_group_dev() and vfio_del_group_dev()
respectively::
- extern int vfio_add_group_dev(struct iommu_group *iommu_group,
- struct device *dev,
+ extern int vfio_add_group_dev(struct device *dev,
const struct vfio_device_ops *ops,
void *device_data);
extern void *vfio_del_group_dev(struct device *dev);
vfio_add_group_dev() indicates to the core to begin tracking the
-specified iommu_group and register the specified dev as owned by
+iommu_group of the specified dev and register the dev as owned by
a VFIO bus driver. The driver provides an ops structure for callbacks
similar to a file operations structure::
-- 1.9.1
.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] VFIO: Fix Documentation
2018-04-20 10:07 ` [PATCH] VFIO: Fix Documentation dongbo (E)
@ 2018-04-30 18:38 ` Alex Williamson
2018-05-07 3:09 ` dongbo (E)
0 siblings, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2018-04-30 18:38 UTC (permalink / raw)
To: dongbo (E); +Cc: corbet, kvm, linux-doc, linux-kernel@vger.kernel.org
On Fri, 20 Apr 2018 18:07:27 +0800
"dongbo (E)" <dongbo4@huawei.com> wrote:
> From: Dong Bo <dongbo4@huawei.com>
>
> Signed-off-by: Dong Bo <dongbo4@huawei.com>
> ---
Hi Dong Bo,
The patch is corrupted, please resend and also include a commit log,
something as simple as "Update vfio_add_group_dev description to match
the current API" would be fine. Thanks,
Alex
> Documentation/vfio.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
> index ef6a511..f1a4d3c 100644
> --- a/Documentation/vfio.txt
> +++ b/Documentation/vfio.txt
> @@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
> the driver should call vfio_add_group_dev() and vfio_del_group_dev()
> respectively::
> - extern int vfio_add_group_dev(struct iommu_group *iommu_group,
> - struct device *dev,
> + extern int vfio_add_group_dev(struct device *dev,
> const struct vfio_device_ops *ops,
> void *device_data);
> extern void *vfio_del_group_dev(struct device *dev);
> vfio_add_group_dev() indicates to the core to begin tracking the
> -specified iommu_group and register the specified dev as owned by
> +iommu_group of the specified dev and register the dev as owned by
> a VFIO bus driver. The driver provides an ops structure for callbacks
> similar to a file operations structure::
> -- 1.9.1
>
>
> .
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] vfio: fix documentation
@ 2018-05-07 3:02 dongbo (E)
2018-05-07 7:53 ` Cornelia Huck
2018-05-08 15:17 ` Jonathan Corbet
0 siblings, 2 replies; 6+ messages in thread
From: dongbo (E) @ 2018-05-07 3:02 UTC (permalink / raw)
To: alex.williamson, corbet; +Cc: kvm, linux-doc, linux-kernel@vger.kernel.org
From: Dong Bo <dongbo4@huawei.com>
Update vfio_add_group_dev description to match the current API.
Signed-off-by: Dong Bo <dongbo4@huawei.com>
---
Documentation/vfio.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
index ef6a511..f1a4d3c 100644
--- a/Documentation/vfio.txt
+++ b/Documentation/vfio.txt
@@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
the driver should call vfio_add_group_dev() and vfio_del_group_dev()
respectively::
- extern int vfio_add_group_dev(struct iommu_group *iommu_group,
- struct device *dev,
+ extern int vfio_add_group_dev(struct device *dev,
const struct vfio_device_ops *ops,
void *device_data);
extern void *vfio_del_group_dev(struct device *dev);
vfio_add_group_dev() indicates to the core to begin tracking the
-specified iommu_group and register the specified dev as owned by
+iommu_group of the specified dev and register the dev as owned by
a VFIO bus driver. The driver provides an ops structure for callbacks
similar to a file operations structure::
--
1.9.1
.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] VFIO: Fix Documentation
2018-04-30 18:38 ` Alex Williamson
@ 2018-05-07 3:09 ` dongbo (E)
0 siblings, 0 replies; 6+ messages in thread
From: dongbo (E) @ 2018-05-07 3:09 UTC (permalink / raw)
To: Alex Williamson; +Cc: corbet, kvm, linux-doc, linux-kernel@vger.kernel.org
Hi, Alex.
On 2018/5/1 2:38, Alex Williamson wrote:
> On Fri, 20 Apr 2018 18:07:27 +0800
> "dongbo (E)" <dongbo4@huawei.com> wrote:
>
>> From: Dong Bo <dongbo4@huawei.com>
>>
>> Signed-off-by: Dong Bo <dongbo4@huawei.com>
>> ---
>
> Hi Dong Bo,
>
> The patch is corrupted, please resend and also include a commit log,
> something as simple as "Update vfio_add_group_dev description to match
> the current API" would be fine. Thanks,
>
> Alex
>
Sorry for the corrupted patch. I've resent one and added the commit log
you suggested. Hope it would apply. Thanks.
Best Regards,
Dong Bo
>> Documentation/vfio.txt | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
>> index ef6a511..f1a4d3c 100644
>> --- a/Documentation/vfio.txt
>> +++ b/Documentation/vfio.txt
>> @@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
>> the driver should call vfio_add_group_dev() and vfio_del_group_dev()
>> respectively::
>> - extern int vfio_add_group_dev(struct iommu_group *iommu_group,
>> - struct device *dev,
>> + extern int vfio_add_group_dev(struct device *dev,
>> const struct vfio_device_ops *ops,
>> void *device_data);
>> extern void *vfio_del_group_dev(struct device *dev);
>> vfio_add_group_dev() indicates to the core to begin tracking the
>> -specified iommu_group and register the specified dev as owned by
>> +iommu_group of the specified dev and register the dev as owned by
>> a VFIO bus driver. The driver provides an ops structure for callbacks
>> similar to a file operations structure::
>> -- 1.9.1
>>
>>
>> .
>>
>>
>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vfio: fix documentation
2018-05-07 3:02 [PATCH] vfio: fix documentation dongbo (E)
@ 2018-05-07 7:53 ` Cornelia Huck
2018-05-08 15:17 ` Jonathan Corbet
1 sibling, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2018-05-07 7:53 UTC (permalink / raw)
To: dongbo (E)
Cc: alex.williamson, corbet, kvm, linux-doc,
linux-kernel@vger.kernel.org
On Mon, 7 May 2018 11:02:10 +0800
"dongbo (E)" <dongbo4@huawei.com> wrote:
> From: Dong Bo <dongbo4@huawei.com>
>
> Update vfio_add_group_dev description to match the current API.
>
> Signed-off-by: Dong Bo <dongbo4@huawei.com>
> ---
> Documentation/vfio.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
> index ef6a511..f1a4d3c 100644
> --- a/Documentation/vfio.txt
> +++ b/Documentation/vfio.txt
> @@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
> the driver should call vfio_add_group_dev() and vfio_del_group_dev()
> respectively::
>
> - extern int vfio_add_group_dev(struct iommu_group *iommu_group,
> - struct device *dev,
> + extern int vfio_add_group_dev(struct device *dev,
> const struct vfio_device_ops *ops,
> void *device_data);
>
> extern void *vfio_del_group_dev(struct device *dev);
>
> vfio_add_group_dev() indicates to the core to begin tracking the
> -specified iommu_group and register the specified dev as owned by
> +iommu_group of the specified dev and register the dev as owned by
> a VFIO bus driver. The driver provides an ops structure for callbacks
> similar to a file operations structure::
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vfio: fix documentation
2018-05-07 3:02 [PATCH] vfio: fix documentation dongbo (E)
2018-05-07 7:53 ` Cornelia Huck
@ 2018-05-08 15:17 ` Jonathan Corbet
1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2018-05-08 15:17 UTC (permalink / raw)
To: dongbo (E); +Cc: alex.williamson, kvm, linux-doc, linux-kernel@vger.kernel.org
On Mon, 7 May 2018 11:02:10 +0800
"dongbo (E)" <dongbo4@huawei.com> wrote:
> Update vfio_add_group_dev description to match the current API.
>
> Signed-off-by: Dong Bo <dongbo4@huawei.com>
Applied, thanks.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-08 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-07 3:02 [PATCH] vfio: fix documentation dongbo (E)
2018-05-07 7:53 ` Cornelia Huck
2018-05-08 15:17 ` Jonathan Corbet
[not found] <1524218521-61496-1-git-send-email-zhangshaokun@hisilicon.com>
2018-04-20 10:07 ` [PATCH] VFIO: Fix Documentation dongbo (E)
2018-04-30 18:38 ` Alex Williamson
2018-05-07 3:09 ` dongbo (E)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).