From: "Tobin C. Harding" <me@tobin.cc>
To: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
"David S. Miller" <davem@davemloft.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] docs: e100[0] fix build errors
Date: Mon, 25 Jun 2018 12:06:23 +1000 [thread overview]
Message-ID: <20180625020623.GJ3006@eros> (raw)
In-Reply-To: <91A1572C-63A6-4420-B01B-A0DD5F84200A@intel.com>
On Mon, Jun 25, 2018 at 01:11:33AM +0000, Kirsher, Jeffrey T wrote:
>
>
> > On Jun 24, 2018, at 16:41, Tobin C. Harding <me@tobin.cc> wrote:
> >
> >> On Fri, Jun 22, 2018 at 01:22:37PM -0700, Randy Dunlap wrote:
> >> Hi Tobin,
> >>
> >>> On 06/21/2018 05:37 PM, Tobin C. Harding wrote:
> >>> Hi Jonathan,
> >>>
> >>> This patch set fixes current docs build failure on Linus' mainline
> >>>
> >>> commit: (ba4dbdedd3ed Merge tag 'jfs-4.18' of git://github.com/kleikamp/linux-shaggy)
> >>>
> >>> (FYI this is 8 commits after Linux 4.18-rc1).
> >>>
> >>> And also same build errors on today's linux-next
> >>>
> >>> 8439c34f07a3 (tag: next-20180621, linux-next/master, linux-next) Add linux-next specific files for 20180621
> >>>
> >>>
> >>> I split the patches in between the two drivers to enable use of the
> >>> 'Fixes:' tag.
> >>>
> >>> Tobin C. Harding (4):
> >>> Documentation: e100: Use correct heading adornment
> >>> Documentation: e1000: Use correct heading adornment
> >>> Documentation: e100: Fix docs build error
> >>> Documentation: e1000: Fix docs build error
> >>>
> >>> Documentation/networking/e100.rst | 112 +++++++++++++++--------------
> >>> Documentation/networking/e1000.rst | 76 ++++++++++----------
> >>> 2 files changed, 96 insertions(+), 92 deletions(-)
> >>
> >> I am still seeing a few warnings (your 4 patches applied to
> >> linux-next-20180622):
> >>
> >> linux-next-20180622/Documentation/networking/e100.rst:57: WARNING: Literal block expected; none found.
> >> linux-next-20180622/Documentation/networking/e100.rst:68: WARNING: Literal block expected; none found.
> >> linux-next-20180622/Documentation/networking/e100.rst:75: WARNING: Literal block expected; none found.
> >> linux-next-20180622/Documentation/networking/e100.rst:84: WARNING: Literal block expected; none found.
> >> linux-next-20180622/Documentation/networking/e100.rst:93: WARNING: Inline emphasis start-string without end-string.
> >> linux-next-20180622/Documentation/networking/e1000.rst:83: ERROR: Unexpected indentation.
> >> linux-next-20180622/Documentation/networking/e1000.rst:84: WARNING: Block quote ends without a blank line; unexpected unindent.
> >> linux-next-20180622/Documentation/networking/e1000.rst:173: WARNING: Definition list ends without a blank line; unexpected unindent.
> >> linux-next-20180622/Documentation/networking/e1000.rst:236: WARNING: Definition list ends without a blank line; unexpected unindent.
> >>
> >>
> >> You didn't get these warnings? or they weren't important?
> >> or "perfect" was not your primary goal? :) [which is fine]
> >>
> >> [I see around 50 similar doc formatting warnings/errors in the entire
> >> Documentation build.]
> >
> > Thanks for testing this Randy. You are right there are a bunch of
> > warnings, I did not think to grep for warnings on these files - sloppy
> > work by me. The series has been applied already but I'll add clearing
> > these warnings to my TODO list.
>
> Thanks, already on it. I have a set of patches that I will push once Dave open’s up his net-next tree.
Oh cool, even better.
thanks,
Tobin.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-06-25 2:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 0:37 [PATCH 0/4] docs: e100[0] fix build errors Tobin C. Harding
2018-06-22 0:37 ` [PATCH 1/4] Documentation: e100: Use correct heading adornment Tobin C. Harding
2018-06-22 16:44 ` Jeff Kirsher
2018-06-22 0:37 ` [PATCH 2/4] Documentation: e1000: " Tobin C. Harding
2018-06-22 16:45 ` Jeff Kirsher
2018-06-22 0:37 ` [PATCH 3/4] Documentation: e100: Fix docs build error Tobin C. Harding
2018-06-22 16:46 ` Jeff Kirsher
2018-06-22 0:37 ` [PATCH 4/4] Documentation: e1000: " Tobin C. Harding
2018-06-22 16:47 ` Jeff Kirsher
2018-06-22 16:44 ` [PATCH 0/4] docs: e100[0] fix build errors Jeff Kirsher
2018-06-23 1:38 ` David Miller
2018-06-22 20:22 ` Randy Dunlap
2018-06-24 23:41 ` Tobin C. Harding
2018-06-25 1:11 ` Kirsher, Jeffrey T
2018-06-25 2:06 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625020623.GJ3006@eros \
--to=me@tobin.cc \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).