linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* PATCH scripts/kernel-doc
@ 2018-07-17 16:57 valdis.kletnieks
  2018-07-17 22:22 ` Mauro Carvalho Chehab
  2018-07-23 15:32 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: valdis.kletnieks @ 2018-07-17 16:57 UTC (permalink / raw)
  To: Jonathan Corbet, Mauro Carvalho Chehab; +Cc: linux-doc, linux-kernel

Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"

Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index 0057d8eafcc1..31a34ced55a3 100755
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc
@@ -1152,7 +1152,7 @@ sub dump_struct($$) {
 	}
 
 	# Ignore other nested elements, like enums
-	$members =~ s/({[^\{\}]*})//g;
+	$members =~ s/(\{[^\{\}]*})//g;
 
 	create_parameterlist($members, ';', $file, $declaration_name);
 	check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
@@ -1176,7 +1176,7 @@ sub dump_struct($$) {
 			$declaration .= "\t" x $level;
 		}
 		$declaration .= "\t" . $clause . "\n";
-		$level++ if ($clause =~ m/({)/ && !($clause =~m/}/));
+		$level++ if ($clause =~ m/(\{)/ && !($clause =~m/}/));
 	}
 	output_declaration($declaration_name,
 			   'struct',

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: PATCH scripts/kernel-doc
  2018-07-17 16:57 PATCH scripts/kernel-doc valdis.kletnieks
@ 2018-07-17 22:22 ` Mauro Carvalho Chehab
  2018-07-23 15:32 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2018-07-17 22:22 UTC (permalink / raw)
  To: valdis.kletnieks
  Cc: Jonathan Corbet, Mauro Carvalho Chehab, linux-doc, linux-kernel

Em Tue, 17 Jul 2018 12:57:29 -0400
valdis.kletnieks@vt.edu escreveu:

> Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"
> 
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>


Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>


> ---
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 0057d8eafcc1..31a34ced55a3 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1152,7 +1152,7 @@ sub dump_struct($$) {
>  	}
>  
>  	# Ignore other nested elements, like enums
> -	$members =~ s/({[^\{\}]*})//g;
> +	$members =~ s/(\{[^\{\}]*})//g;
>  
>  	create_parameterlist($members, ';', $file, $declaration_name);
>  	check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
> @@ -1176,7 +1176,7 @@ sub dump_struct($$) {
>  			$declaration .= "\t" x $level;
>  		}
>  		$declaration .= "\t" . $clause . "\n";
> -		$level++ if ($clause =~ m/({)/ && !($clause =~m/}/));
> +		$level++ if ($clause =~ m/(\{)/ && !($clause =~m/}/));
>  	}
>  	output_declaration($declaration_name,
>  			   'struct',
> 




Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH scripts/kernel-doc
  2018-07-17 16:57 PATCH scripts/kernel-doc valdis.kletnieks
  2018-07-17 22:22 ` Mauro Carvalho Chehab
@ 2018-07-23 15:32 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2018-07-23 15:32 UTC (permalink / raw)
  To: valdis.kletnieks; +Cc: Mauro Carvalho Chehab, linux-doc, linux-kernel

On Tue, 17 Jul 2018 12:57:29 -0400
valdis.kletnieks@vt.edu wrote:

> Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"
> 
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.

Applied, thanks.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-23 15:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 16:57 PATCH scripts/kernel-doc valdis.kletnieks
2018-07-17 22:22 ` Mauro Carvalho Chehab
2018-07-23 15:32 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).