From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 7DA9B7D2EE for ; Fri, 24 Aug 2018 15:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726677AbeHXSnz (ORCPT ); Fri, 24 Aug 2018 14:43:55 -0400 Received: from mail.bootlin.com ([62.4.15.54]:55397 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbeHXSnz (ORCPT ); Fri, 24 Aug 2018 14:43:55 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id D257F22A2A; Fri, 24 Aug 2018 17:08:50 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-53-19.w90-88.abo.wanadoo.fr [90.88.170.19]) by mail.bootlin.com (Postfix) with ESMTPSA id 1AA0B20719; Fri, 24 Aug 2018 17:08:50 +0200 (CEST) Date: Fri, 24 Aug 2018 17:08:48 +0200 From: Boris Brezillon To: Bartosz Golaszewski Cc: Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King , Arnd Bergmann , Greg Kroah-Hartman , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Naren , Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , Florian Fainelli , Ivan Khoronzhuk , Sven Van Asbroeck , Paolo Abeni , Alban Bedel , Rob Herring , David Lechner , Andrew Lunn , linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/29] nvmem: add support for cell lookups Message-ID: <20180824170848.29594318@bbrezillon> In-Reply-To: <20180810080526.27207-2-brgl@bgdev.pl> References: <20180810080526.27207-1-brgl@bgdev.pl> <20180810080526.27207-2-brgl@bgdev.pl> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Bartosz, On Fri, 10 Aug 2018 10:04:58 +0200 Bartosz Golaszewski wrote: > +struct nvmem_cell_lookup { > + struct nvmem_cell_info info; > + struct list_head list; > + const char *nvmem_name; > +}; Hm, maybe I don't get it right, but this looks suspicious. Usually the consumer lookup table is here to attach device specific names to external resources. So what I'd expect here is: struct nvmem_cell_lookup { /* The nvmem device name. */ const char *nvmem_name; /* The nvmem cell name */ const char *nvmem_cell_name; /* * The local resource name. Basically what you have in the * nvmem-cell-names prop. */ const char *conid; }; struct nvmem_cell_lookup_table { struct list_head list; /* ID of the consumer device. */ const char *devid; /* Array of cell lookup entries. */ unsigned int ncells; const struct nvmem_cell_lookup *cells; }; Looks like your nvmem_cell_lookup is more something used to attach cells to an nvmem device, which is NVMEM provider's responsibility not the consumer one. Regards, Boris