Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM

Randy Dunlap
2018-09-03T02:19:25Z

On 09/02/2018 05:52 PM, Kenneth Lee wrote:
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index 1d155708cd69..b85fab48fdab 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -17,6 +17,16 @@ config CRYPTO_DEV_HISI_SEC
> To compile this as a module, choose M here: the module
> will be called hisi_sec.
>
> +config CRYPTO_DEV_HISI_SDMDEV
> + bool "Enable SDMDEV interface"
> + depends on CRYPTO_DEV_HISILICON
> + select VFIO_SDMDEV
> + help
> + Enable this enable the SDMDEV, "shared IOMMU Domain Mediated Device"

At a minimum:
Enable this to enable the SDMDEV,

although that could be done better. Maybe just:
Enable the SDMDEV "shared IOMMU Domain Mediated Device"

> + interface for all Hisilicon accelerators if they can. The SDMDEV

probably drop "if they can": accelerators. The SDMDEV interface

> + enable the WarpDrive user space accelerator driver to access the

enables

> + hardware function directly.
> +

--
~Randy