From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 79CE37D57F for ; Wed, 5 Sep 2018 14:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbeIETad (ORCPT ); Wed, 5 Sep 2018 15:30:33 -0400 Received: from mail.bootlin.com ([62.4.15.54]:53129 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbeIETac (ORCPT ); Wed, 5 Sep 2018 15:30:32 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 63C3C208B5; Wed, 5 Sep 2018 16:59:57 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-92-107.w90-88.abo.wanadoo.fr [90.88.33.107]) by mail.bootlin.com (Postfix) with ESMTPSA id DA8E620741; Wed, 5 Sep 2018 16:59:46 +0200 (CEST) Date: Wed, 5 Sep 2018 16:59:45 +0200 From: Boris Brezillon To: Bartosz Golaszewski Cc: Srinivas Kandagatla , Joachim Eastwood , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Andrew Lunn , Alban Bedel , Maxime Ripard , linux-doc , Linux Kernel Mailing List , Linux ARM , Bartosz Golaszewski Subject: Re: [PATCH 11/13] nvmem: add support for cell lookups from machine code Message-ID: <20180905165945.6101d62e@bbrezillon> In-Reply-To: References: <20180905095738.26406-1-brgl@bgdev.pl> <20180905095738.26406-12-brgl@bgdev.pl> <20180905155741.22b7d0ef@bbrezillon> <20180905162135.700d2145@bbrezillon> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 5 Sep 2018 16:47:57 +0200 Bartosz Golaszewski wrote: > 2018-09-05 16:21 GMT+02:00 Boris Brezillon : > > On Wed, 5 Sep 2018 16:00:36 +0200 > > Bartosz Golaszewski wrote: > > > >> 2018-09-05 15:57 GMT+02:00 Boris Brezillon : > >> > On Wed, 5 Sep 2018 11:57:36 +0200 > >> > Bartosz Golaszewski wrote: > >> > > >> >> > >> >> +struct nvmem_cell_lookup { > >> >> + const char *nvmem_name; > >> >> + const char *dev_id; > >> > > >> > Shouldn't we have a con_id here? > >> > > >> >> + const char *cell_id; > >> >> + struct list_head node; > >> >> +}; > >> > >> I wanted to stay in line with the current API - nvmem_cell_get() takes > >> as argument a string called cell_id. I wanted to reflect that here. > > > > Actually, you need both. con_id is the name you would have in your DT > > in the nvmem-cell-names property, cell_id is the name of the cell > > you'd find under the nvmem device node. > > > > Let's take an example: > > > > mydev { > > #nvmem-cell-names = "mac-address", "revision"; > > #nvmem-cells = <&cell1>, <&cell2>; > > }; > > > > mynvmemdev { > > #size-cells = <1>; > > #address-cells = <1>; > > > > cell1: foo@0 { > > reg = <0x0 0x6>; > > }; > > > > cell2: bar@6 { > > reg = <0x6 0x10>; > > }; > > }; > > > > this can be described the same way using a consumer lookup table: > > > > struct nvmem_cell_lookup_entry { > > const char *con_id; > > const char *nvmem_name; > > const char *cell_name; > > }; > > > > struct nvmem_cell_lookup_table { > > struct list_head node; > > const char *dev_id; > > unsigned int nentries; > > const struct nvmem_cell_lookup_entry *entries; > > } > > > > static const struct nvmem_cell_lookup_entry mydev_nvmem_cells[] = { > > { > > .con_id = "mac-address", > > .nvmem_name = "mynvmemdev", > > .cell_name = "foo", > > }, > > { > > .con_id = "revision", > > .nvmem_name = "mynvmemdev", > > .cell_name = "bar", > > }, > > } > > > > static const struct nvmem_cell_lookup_table mydev_nvmem_lookup = { > > .dev_id = "mydev.0", > > .nentries = ARRAY_SIZE(mydev_nvmem_cells), > > .entries = mydev_nvmem_cells, > > }; > > > > > > ... > > > > nvmem_add_cell_lookups(&mydev_nvmem_lookup); > > Ok I get it. Shouldn't we change the argument name of nvmem_cell_get() > and friends from 'name' to 'con_id' or simply 'id' similarly to what > other frameworks do to avoid such confusion? I'll let Srinivas answer that one. > > I also don't see a need for splitting the lookup into two structures > here. Something like: > > struct nvmem_cell_lookup { > const char *nvmem_name; > const char *cell_name; > const char *dev_id; > const char *con_id; > }; > > Would be perfectly fine and would allow to register all lookups for > given machine with a single call. Yep, makes sense.