From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id EBE217D581 for ; Sat, 22 Sep 2018 13:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731136AbeIVTkD (ORCPT ); Sat, 22 Sep 2018 15:40:03 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36660 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729730AbeIVTkD (ORCPT ); Sat, 22 Sep 2018 15:40:03 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8MDi45J005543 for ; Sat, 22 Sep 2018 09:46:23 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mnkxkvysm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 22 Sep 2018 09:46:22 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 22 Sep 2018 09:46:22 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 22 Sep 2018 09:46:17 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8MDkGVI29753460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 22 Sep 2018 13:46:16 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B314B2064; Sat, 22 Sep 2018 09:44:42 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C47DEB205F; Sat, 22 Sep 2018 09:44:41 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.211.27]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sat, 22 Sep 2018 09:44:41 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 84B4016C1D07; Sat, 22 Sep 2018 06:46:16 -0700 (PDT) Date: Sat, 22 Sep 2018 06:46:16 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: LKML , Jonathan Corbet , Josh Triplett , Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , Steven Rostedt Subject: Re: [PATCH RFC] Documentation: RCU: Clarify comment about fanout Reply-To: paulmck@linux.ibm.com References: <20180921223153.114728-1-joel@joelfernandes.org> <20180922011428.GU4222@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18092213-0068-0000-0000-000003406D28 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009751; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01092029; UDB=6.00564291; IPR=6.00872053; MB=3.00023450; MTD=3.00000008; XFM=3.00000015; UTC=2018-09-22 13:46:20 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092213-0069-0000-0000-000045D26BFB Message-Id: <20180922134616.GX4222@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-22_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809220146 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sat, Sep 22, 2018 at 04:10:51AM -0400, Joel Fernandes wrote: > On Fri, Sep 21, 2018 at 9:14 PM Paul E. McKenney wrote: > > > > On Fri, Sep 21, 2018 at 06:31:53PM -0400, Joel Fernandes (Google) wrote: > > > RCU Data-Structures document describes a trick to test RCU with small > > > number of CPUs but with a larger tree. It wasn't immediately clear how > > > the document arrived at 16 CPUs which also requires setting the > > > FANOUT_LEAF to 2 instead of the default of 16. Clarify that. > > > > > > Signed-off-by: Joel Fernandes (Google) > > > > Good catch, applied, thank you! You know, those two Kconfig options > > are so closely linked in my mind that I doubt if I would ever have > > noticed this issue. So good show! > > Thanks! > > > I of course could not resist doing a bit of editing. Could you please > > check the following to make sure that I didn't mess something up? > > Yes, the edit looks good and improved the changes ;-) Whew! > I have a few more as well, I'll send them out soon. I do have on my list to update this document based on the changes in -rcu, which among other things eliminate the rcu_dynticks structure and make it so there is only one rcu_state structure in a given running system. If you are crazy enough to want to make the corresponding changes, I would welcome the patches (and would be happy to help with editing, grammar, and soforth. The potential advantage to you is familiarlzation with the new version of the code. This is not a small amount of work, so please give it some thought before saying "yes". (In contrast, I would of course understand and respect an immediate "no".) Thanx, Paul > thanks! > > - Joel > > > > > > Thanx, Paul > > > > ------------------------------------------------------------------------ > > > > commit 9870c5b0f7b41a7b6085c20c22b320681800dabc > > Author: Joel Fernandes (Google) > > Date: Fri Sep 21 18:31:53 2018 -0400 > > > > doc: Clarify RCU data-structure comment about rcu_tree fanout > > > > RCU Data-Structures document describes a trick to test RCU with small > > number of CPUs but with a taller tree. It wasn't immediately clear how > > the document arrived at 16 CPUs which also requires setting the > > FANOUT_LEAF to 2 instead of the default of 16. This commit therefore > > provides the needed clarification. > > > > Signed-off-by: Joel Fernandes (Google) > > Signed-off-by: Paul E. McKenney > > > > diff --git a/Documentation/RCU/Design/Data-Structures/Data-Structures.html b/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > index 1d2051c0c3fc..476b1ac38e4c 100644 > > --- a/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > +++ b/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > @@ -127,9 +127,11 @@ CPUs, RCU would configure the rcu_node tree as follows: > >

RCU currently permits up to a four-level tree, which on a 64-bit system > > accommodates up to 4,194,304 CPUs, though only a mere 524,288 CPUs for > > 32-bit systems. > > -On the other hand, you can set CONFIG_RCU_FANOUT to be > > -as small as 2 if you wish, which would permit only 16 CPUs, which > > -is useful for testing. > > +On the other hand, you can set both CONFIG_RCU_FANOUT and > > +CONFIG_RCU_FANOUT_LEAF to be as small as 2, which would result > > +in a 16-CPU test using a 4-level tree. > > +This can be useful for testing large-system capabilities on small test > > +machines. > > > >

This multi-level combining tree allows us to get most of the > > performance and scalability > > >