From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-doc@vger.kernel.org, tglx@linutronix.de,
kirill.shutemov@linux.intel.com, thgarnie@google.com,
corbet@lwn.net
Subject: Re: [PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions
Date: Wed, 3 Oct 2018 16:45:57 +0800 [thread overview]
Message-ID: <20181003084557.GB5140@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20181002091412.GE116695@gmail.com>
On 10/02/18 at 11:14am, Ingo Molnar wrote:
>
> * Baoquan He <bhe@redhat.com> wrote:
> > -ffffffff80000000 - ffffffff9fffffff (=512 MB) kernel text mapping, from phys 0
> > -ffffffffa0000000 - fffffffffeffffff (1520 MB) module mapping space
> > +fffffe0000000000 - fffffe7fffffffff (=39 bits, 512 GB) cpu_entry_area mapping
> > +fffffe8000000000 - fffffeffffffffff (=39 bits, 512 GB) LDT remap for PTI
> > +ffffff0000000000 - ffffff7fffffffff (=39 bits, 512 GB) %esp fixup stacks
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits, 64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits, 2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits, 512 MB) kernel text mapping, from phys 0
> > +ffffffffa0000000 - fffffffffeffffff (~31 bits, 1520 MB) module mapping space
> > [fixmap start] - ffffffffff5fffff kernel-internal fixmap range
> > ffffffffff600000 - ffffffffff600fff (=4 kB) legacy vsyscall ABI
> > ffffffffffe00000 - ffffffffffffffff (=2 MB) unused hole
>
> Looks mostly good now, but could you please make the right side align vertically as well, like
> I did in the examples I provided previously?
>
> There's zero reason for it to look this disorganized:
>
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits, 64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits, 2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits, 512 MB) kernel text mapping, from phys 0
>
> I.e. can we do something like:
>
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits, 64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits, 2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits, 512 MB) kernel text mapping, from phys 0
Sure, will change according to your suggestion. Thanks a lot!
>
> ?
>
> That not only makes it more readable, but makes typos like the whitespace noise double space in
> the last line more obvious.
>
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2018-10-03 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 23:58 [PATCH v2 0/3] x86/mm/doc: Clean up mm.txt Baoquan He
2018-09-26 23:58 ` [PATCH v2 1/3] x86/KASLR: Update document about KERNEL_IMAGE_SIZE Baoquan He
2018-10-03 7:52 ` Ingo Molnar
2018-10-03 8:43 ` Baoquan He
2018-09-26 23:58 ` [PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions Baoquan He
2018-10-02 9:14 ` Ingo Molnar
2018-10-03 8:45 ` Baoquan He [this message]
2018-09-26 23:58 ` [PATCH v2 3/3] x86/doc/kaslr.txt: Create a separate part of document abourt KASLR at the end of file Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003084557.GB5140@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).