From: Petr Mladek <pmladek@suse.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Tobin C . Harding" <me@tobin.cc>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/3] lib/vsprintf: Hash legacy clock addresses
Date: Tue, 9 Oct 2018 16:05:40 +0200 [thread overview]
Message-ID: <20181009140540.mz77x5a7bfmupxbb@pathway.suse.cz> (raw)
In-Reply-To: <20181008110504.25449-3-geert+renesas@glider.be>
On Mon 2018-10-08 13:05:03, Geert Uytterhoeven wrote:
> On platforms using the Common Clock Framework, "%pC" prints the clock's
> name. On legacy platforms, it prints the unhashed clock's address,
> potentially leaking sensitive information regarding the kernel layout in
> memory.
>
> Avoid this leak by printing the hashed address instead. To distinguish
> between clocks, a 32-bit unique identifier is as good as an actual
> pointer value.
>
> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
It makes sense.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2018-10-09 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 11:05 [PATCH 0/3] lib/vsprintf: Hash remaining raw addresses Geert Uytterhoeven
2018-10-08 11:05 ` [PATCH 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id() Geert Uytterhoeven
2018-10-08 14:25 ` Andy Shevchenko
2018-10-08 14:37 ` Geert Uytterhoeven
2018-10-08 14:55 ` Andy Shevchenko
2018-10-09 13:56 ` Petr Mladek
2018-10-09 14:15 ` Geert Uytterhoeven
2018-10-08 11:05 ` [PATCH 2/3] lib/vsprintf: Hash legacy clock addresses Geert Uytterhoeven
2018-10-09 14:05 ` Petr Mladek [this message]
2018-10-08 11:05 ` [PATCH 3/3] lib/vsprintf: Hash printed address for netdev bits fallback Geert Uytterhoeven
2018-10-09 14:18 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009140540.mz77x5a7bfmupxbb@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).