From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support
Date: Thu, 11 Oct 2018 12:36:59 -0700 [thread overview]
Message-ID: <20181011193658.GA3828@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20181011193152.GA4854@roeck-us.net>
On Thu, Oct 11, 2018 at 12:31:52PM -0700, Guenter Roeck wrote:
> > One more question here, and this might sound a bit abuse of using
> > the existing hwmon ABI: would it sound plausible to you that the
> > driver powers down the chip when all three channels get disabled
> > via in[123]_enable nodes? :)
> >
>
> I would not call that an abuse, no.
Hmm..do you mean that you aren't in favor of powering down the chip
after all channels get disabled?
I was thinking about having pm_runtime_get_sync()/put() for channel
enabling/disabling routine of in[123]_enable.
Thanks
Nicolin
next prev parent reply other threads:[~2018-10-11 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 4:33 [PATCH 0/2] hwmon: Add operating mode support for core and ina3221 Nicolin Chen
2018-10-10 4:33 ` [PATCH 1/2] hwmon: (core) Add hwmon_mode structure and mode sysfs node Nicolin Chen
2018-10-10 13:08 ` Guenter Roeck
2018-10-10 21:13 ` Nicolin Chen
2018-10-10 21:31 ` Guenter Roeck
2018-10-10 4:33 ` [PATCH 2/2] hwmon: (ina3221) Add operating mode support Nicolin Chen
2018-10-10 13:22 ` Guenter Roeck
2018-10-10 23:09 ` Nicolin Chen
2018-10-10 23:43 ` Guenter Roeck
2018-10-11 0:24 ` Nicolin Chen
2018-10-11 19:31 ` Guenter Roeck
2018-10-11 19:36 ` Nicolin Chen [this message]
2018-10-11 19:50 ` Guenter Roeck
2018-10-11 19:53 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011193658.GA3828@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).