linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Robert Love <rml@tech9.net>,
	kpreempt-tech@lists.sourceforge.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: preempt-locking: Use better example
Date: Fri, 12 Oct 2018 11:36:56 -0600	[thread overview]
Message-ID: <20181012113656.771e8dd1@lwn.net> (raw)
In-Reply-To: <1539004515-8152-1-git-send-email-andrew.murray@arm.com>

On Mon,  8 Oct 2018 14:15:15 +0100
Andrew Murray <andrew.murray@arm.com> wrote:

> The existing wording implies that the use of spin_unlock whilst irqs are
> disabled might trigger a reschedule. However the preemptible() test in
> preempt_schedule will prevent a reschedule if irqs are disabled.
> 
> Lets improve the clarity of this wording to change the example from
> spin_unlock to cond_resched() and cond_resched_lock() as these are
> functions that will trigger a reschedule if the preempt count is 0 without
> testing that irqs are disabled.
> 
> Also remove the 'Last Updated' line as this is not up to date and better
> tracked via GIT.
> 
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>

I've applied this, but that document is ... old.  It sure would be nice if
somebody found the energy to write a proper locking document for current
kernels...:)

Thanks,

jon

      reply	other threads:[~2018-10-12 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 13:15 [PATCH] Documentation: preempt-locking: Use better example Andrew Murray
2018-10-12 17:36 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012113656.771e8dd1@lwn.net \
    --to=corbet@lwn.net \
    --cc=andrew.murray@arm.com \
    --cc=kpreempt-tech@lists.sourceforge.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@tech9.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).