Re: [PATCH] docs/uio: fix a grammar nitpick

Re: [PATCH] docs/uio: fix a grammar nitpick

[Greg KH]

On Sat, Oct 13, 2018 at 09:47:46PM +0000, Will Korteland wrote:
> This patch fixes a minor, incorrect piece of grammar in the UIO howto.
> 
> Signed-off-by: Will Korteland <will@korte.land>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> This is my first attempt at a kernel patch, so please let me know if
> I've done something silly.

You sent this in html format :(

Also, the non-html format did not apply to the tree, can you redo this
against linux-next and resend it?

thanks,

greg k-h

[PATCH] docs/uio: fix a grammar nitpick

[Will Korteland]

This patch fixes a minor, incorrect piece of grammar in the UIO howto.

Signed-off-by: Will Korteland <will@korte.land>
---
This is my first attempt at a kernel patch, so please let me know if
I've done something silly.  I sent a copy of this a few days ago, but
I can't find it on the public archives - apologies if I've now posted
this twice.

  Documentation/driver-api/uio-howto.rst | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/driver-api/uio-howto.rst 
b/Documentation/driver-api/uio-howto.rst
index fb2eb73be4a3..25f50eace28b 100644
--- a/Documentation/driver-api/uio-howto.rst
+++ b/Documentation/driver-api/uio-howto.rst
@@ -463,8 +463,8 @@ Getting information about your UIO device

  Information about all UIO devices is available in sysfs. The first 
thing
  you should do in your driver is check ``name`` and ``version`` to make
-sure your talking to the right device and that its kernel driver has 
the
-version you expect.
+sure you're talking to the right device and that its kernel driver has
+the version you expect.

  You should also make sure that the memory mapping you need exists and
  has the size you expect.
-- 
2.19.1

Re: [PATCH] docs/uio: fix a grammar nitpick

[Randy Dunlap]

On 10/15/18 1:10 AM, Will Korteland wrote:
> This patch fixes a minor, incorrect piece of grammar in the UIO howto.
> 
> Signed-off-by: Will Korteland <will@korte.land>

Looks good to me.  Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
> This is my first attempt at a kernel patch, so please let me know if
> I've done something silly.  I sent a copy of this a few days ago, but
> I can't find it on the public archives - apologies if I've now posted
> this twice.
> 
>  Documentation/driver-api/uio-howto.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/driver-api/uio-howto.rst b/Documentation/driver-api/uio-howto.rst
> index fb2eb73be4a3..25f50eace28b 100644
> --- a/Documentation/driver-api/uio-howto.rst
> +++ b/Documentation/driver-api/uio-howto.rst
> @@ -463,8 +463,8 @@ Getting information about your UIO device
> 
>  Information about all UIO devices is available in sysfs. The first thing
>  you should do in your driver is check ``name`` and ``version`` to make
> -sure your talking to the right device and that its kernel driver has the
> -version you expect.
> +sure you're talking to the right device and that its kernel driver has
> +the version you expect.
> 
>  You should also make sure that the memory mapping you need exists and
>  has the size you expect.


-- 
~Randy