From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 1848D7D089 for ; Mon, 29 Oct 2018 13:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725964AbeJ2W3s (ORCPT ); Mon, 29 Oct 2018 18:29:48 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbeJ2W3s (ORCPT ); Mon, 29 Oct 2018 18:29:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7tOo3mOK1RhCIFMhClp70+XyUYGv1gfIsS6PyLmMgJM=; b=HnokiOq4Tly7OCMPlmMDSRKxVp mWbkYnOTCGE3vShL6H50qNxIhL66pqHkzKmPKxKYmcopgoIoevXegcSvdGuvwdswGeBptDP/1DI+G Gt8T2tAAVkrMjRuXeEyo/ckM0VOP7kAQFJgfQPxnD+KM5Y3KcsdKXC2E5yhOdsUDmnqKUN/Fyf+G0 jhggGCjM0mZPMOe2Q1qP+1ljTl+FwlYMjDQtWMnkt9MfGQI/6IR70mj3cwnZxdXt2X396AzN1ThZ1 G4/CBl7keWa+aL1nW+psS9j55MBfHwfHdQ7QY2mC0NH/d0tu8nzNXUfUcl8ptzv02bTO6vmIrlHsW PwTZ+rJA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH7mu-0003HR-R5; Mon, 29 Oct 2018 13:41:00 +0000 Date: Mon, 29 Oct 2018 06:41:00 -0700 From: Matthew Wilcox To: Vitor soares Cc: boris.brezillon@bootlin.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, psroka@cadence.com, agolec@cadence.com, adouglas@cadence.com, bfolta@cadence.com, dkos@cadence.com, alicja@cadence.com, cwronka@cadence.com, sureshp@cadence.com, rafalc@cadence.com, thomas.petazzoni@bootlin.com, nm@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, linus.walleij@linaro.org, Xiang.Lin@synaptics.com, linux-gpio@vger.kernel.org, nsekhar@ti.com, pgaj@cadence.com, peda@axentia.se, mshettel@codeaurora.org, swboyd@chromium.org, joao.pinto@synopsys.com, luis.oliveira@synopsys.com, manuel.abreu@synopsys.com, gustavo.pimentel@synopsys.com Subject: Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP Message-ID: <20181029134100.GD28520@bombadil.infradead.org> References: <1540807618-13246-1-git-send-email-soares@synopsys.com> <1540807618-13246-2-git-send-email-soares@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1540807618-13246-2-git-send-email-soares@synopsys.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote: > +config DW_I3C_MASTER > + tristate "Synospsys DesignWare I3C master driver" > + depends on I3C > + depends on !(ALPHA || PARISC) why? > + help > + Support·for·Synopsys·DesignWare·MIPI·I3C·Controller. These strange characters (displayed as a centred dot on my terminal) should probably be spaces. > +static struct dw_i3c_xfer * > +dw_i3c_master_alloc_xfer(struct dw_i3c_master *master, unsigned int ncmds) > +{ > + struct dw_i3c_xfer *xfer; > + > + xfer = kzalloc(sizeof(*xfer) + (ncmds * sizeof(*xfer->cmds)), > + GFP_KERNEL); You should be using struct_size() here.