From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 6147A7D08A for ; Tue, 6 Nov 2018 14:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388717AbeKGABH (ORCPT ); Tue, 6 Nov 2018 19:01:07 -0500 Received: from ms.lwn.net ([45.79.88.28]:37966 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388690AbeKGABH (ORCPT ); Tue, 6 Nov 2018 19:01:07 -0500 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 57A322CD; Tue, 6 Nov 2018 14:35:37 +0000 (UTC) Date: Tue, 6 Nov 2018 07:35:36 -0700 From: Jonathan Corbet To: Christoph Niedermaier Cc: , , , Subject: Re: [PATCH 0/2] Docs/EDID: Fixed and improved EDID documentation Message-ID: <20181106073536.58b14759@lwn.net> In-Reply-To: <1541407715-5417-1-git-send-email-cniedermaier@dh-electronics.de> References: <1541407715-5417-1-git-send-email-cniedermaier@dh-electronics.de> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 5 Nov 2018 09:48:33 +0100 Christoph Niedermaier wrote: > A problem was found when EDID data sets for displays other > than the provided samples were generated. The patch series has > no effect on the provided samples that still match the data > used in drivers/gpu/drm/drm_edid_load.c. > The provided samples use small values for XOFFSET, XPULSE, > YOFFSET and YPULSE, where the error doesn't occur. This fix > corrects the use of that values in case of high values, because > the most significant bits were treated incorrectly. > > The previous version made it necessary to first generate an > EDID data set without correct CRC and then to fix the CRC in > a second step. This patch series adds the CRC calculation to the > makefile in such a way that a correct EDID data set is generated > in a single build step. This seems reasonable, I guess; I've applied both. It seems to me, though, that this stuff is in the wrong place. Perhaps we should go one step further and move it to tools/ ? Thanks, jon