From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id BF6327D08A for ; Fri, 9 Nov 2018 20:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbeKJGfj (ORCPT ); Sat, 10 Nov 2018 01:35:39 -0500 Received: from mail-eopbgr740057.outbound.protection.outlook.com ([40.107.74.57]:29728 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725799AbeKJGe7 (ORCPT ); Sat, 10 Nov 2018 01:34:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KVcy8HpXOJwPtcJRpYC8zooaRYElMrQ4h7GlHaLrWS4=; b=zk1S66lT5Cycn0caHuPCdPBh4lzb97QDG58srFmrfFXEGLldZyQFL2r/+dQ6B7+kD+P80MrPtaamqSavvTeLzNAlosw2dFYcJLpEszbCdfwbz/g5d3foRy+6OQIVs8Ba2M1Me1vHR/RDO4EQYCtU/YU6AO8x21/E0WiuR5X0A8w= Received: from DM5PR12MB2471.namprd12.prod.outlook.com (52.132.141.138) by DM5PR12MB1675.namprd12.prod.outlook.com (10.172.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.23; Fri, 9 Nov 2018 20:52:35 +0000 Received: from DM5PR12MB2471.namprd12.prod.outlook.com ([fe80::4c23:f551:bc6a:554e]) by DM5PR12MB2471.namprd12.prod.outlook.com ([fe80::4c23:f551:bc6a:554e%4]) with mapi id 15.20.1294.034; Fri, 9 Nov 2018 20:52:35 +0000 From: "Moger, Babu" To: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "reinette.chatre@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" CC: "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "Moger, Babu" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: [PATCH v7 06/13] arch/x86: Initialize the resource functions that are different Thread-Topic: [PATCH v7 06/13] arch/x86: Initialize the resource functions that are different Thread-Index: AQHUeG4kf8XlQVjR0k+e0T1U3dZ7Wg== Date: Fri, 9 Nov 2018 20:52:35 +0000 Message-ID: <20181109205153.14811-7-babu.moger@amd.com> References: <20181109205153.14811-1-babu.moger@amd.com> In-Reply-To: <20181109205153.14811-1-babu.moger@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN4PR0701CA0005.namprd07.prod.outlook.com (2603:10b6:803:28::15) To DM5PR12MB2471.namprd12.prod.outlook.com (2603:10b6:4:b5::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [165.204.78.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR12MB1675;20:0WsvqvvaCLhrU1I+pZUxwY0016PWTOLuN9iTrFiD3vG8oSwDAfqun/olODsyxCfldnCRGwyfc95b+Ws271DyjwHscLNl0FVnuGUwOmJivq6EeMXF7fUYK1t+05zF+cAi1K0D8Ja/QtYmg84Pbnhx5HupoSvwfVOJ243kvNOhHc9437aDT3j88gNTggoLUgqi38CCf3khuSUyq9VUKOQ8S/phVfud7+/N8R9kBhFI6YddFkVG+42yILS45hvv3DPC x-ms-office365-filtering-correlation-id: 18a7650c-7e4e-4dc7-4f91-08d6468546a5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:DM5PR12MB1675; x-ms-traffictypediagnostic: DM5PR12MB1675: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(269456686620040)(767451399110); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302103)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095);SRVR:DM5PR12MB1675;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1675; x-forefront-prvs: 08512C5403 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(376002)(396003)(346002)(136003)(366004)(199004)(189003)(305945005)(4326008)(14454004)(6116002)(66066001)(72206003)(36756003)(105586002)(6486002)(3846002)(6436002)(102836004)(386003)(6506007)(6512007)(478600001)(99286004)(2906002)(5660300001)(25786009)(86362001)(2900100001)(68736007)(575784001)(2501003)(2201001)(26005)(11346002)(7406005)(81156014)(446003)(81166006)(486006)(476003)(2616005)(186003)(1076002)(52116002)(53936002)(8936002)(7736002)(106356001)(14444005)(256004)(110136005)(71200400001)(76176011)(71190400001)(8676002)(54906003)(316002)(7416002)(97736004)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1675;H:DM5PR12MB2471.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ppvQMP8176upWNVrV3EIa832WLD48Nw2GQSFYIYFzloeYFMm6YzBWKZ2H++VuoGvrEsXEHuXBpoKUBQRaBem9Twy9CtAtgSbL0KD5qnoQ+fEXLOVtsPbY12zhWzkkJ/zGNOEAcxjnmu0e+WWwrjYriIzO8iVGj/oKSEZzqP9LpIlRwGo4cI4zd3qiwgUOr9EemoPJ/UmKzvGWWF4AgkjxODmUA4NVQSMSEhRbwk9txGOwsnYnIrzi2+l3brDhMz9VmjOkZ5favTOKkAsGqJC1/4mpT1GSOJDKjgA1wE6Yh41vyG5OIsKN2CCbQrjLe1dFmfXKXK/01SevW/vETmD39xhINs3Oedu+bu2Jd+gNbA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a7650c-7e4e-4dc7-4f91-08d6468546a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2018 20:52:35.1348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1675 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Initialize the resource functions that are different between the vendors. Some features are initialized differently between the vendors. Add _intel suffix to Intel specific functions. For example, MBA feature varies significantly between Intel and AMD. Separate the initialization of these resource functions. That way we can easily add AMD's functions later. Signed-off-by: Babu Moger --- arch/x86/kernel/cpu/resctrl.c | 34 +++++++++++++++++++---- arch/x86/kernel/cpu/resctrl.h | 8 ++++-- arch/x86/kernel/cpu/resctrl_ctrlmondata.c | 4 +-- 3 files changed, 37 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl.c b/arch/x86/kernel/cpu/resctrl.c index ddb2c65a309a..3f77d5fcb2dc 100644 --- a/arch/x86/kernel/cpu/resctrl.c +++ b/arch/x86/kernel/cpu/resctrl.c @@ -57,7 +57,8 @@ int max_name_width, max_data_width; bool rdt_alloc_capable; =20 static void -mba_wrmsr(struct rdt_domain *d, struct msr_param *m, struct rdt_resource *= r); +mba_wrmsr_intel(struct rdt_domain *d, struct msr_param *m, + struct rdt_resource *r); static void cat_wrmsr(struct rdt_domain *d, struct msr_param *m, struct rdt_resource *= r); =20 @@ -171,10 +172,7 @@ struct rdt_resource rdt_resources_all[] =3D { .rid =3D RDT_RESOURCE_MBA, .name =3D "MB", .domains =3D domain_init(RDT_RESOURCE_MBA), - .msr_base =3D IA32_MBA_THRTL_BASE, - .msr_update =3D mba_wrmsr, .cache_level =3D 3, - .parse_ctrlval =3D parse_bw, .format_str =3D "%d=3D%*u", .fflags =3D RFTYPE_RES_MB, }, @@ -356,7 +354,8 @@ u32 delay_bw_map(unsigned long bw, struct rdt_resource = *r) } =20 static void -mba_wrmsr(struct rdt_domain *d, struct msr_param *m, struct rdt_resource *= r) +mba_wrmsr_intel(struct rdt_domain *d, struct msr_param *m, + struct rdt_resource *r) { unsigned int i; =20 @@ -875,6 +874,25 @@ static __init bool get_rdt_resources(void) return (rdt_mon_capable || rdt_alloc_capable); } =20 +static __init void rdt_init_res_defs_intel(void) +{ + struct rdt_resource *r; + + for_each_rdt_resource(r) { + if (r->rid =3D=3D RDT_RESOURCE_MBA) { + r->msr_base =3D IA32_MBA_THRTL_BASE; + r->msr_update =3D mba_wrmsr_intel; + r->parse_ctrlval =3D parse_bw_intel; + } + } +} + +static __init void rdt_init_res_defs(void) +{ + if (boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL) + rdt_init_res_defs_intel(); +} + static enum cpuhp_state rdt_online; =20 static int __init resctrl_late_init(void) @@ -882,6 +900,12 @@ static int __init resctrl_late_init(void) struct rdt_resource *r; int state, ret; =20 + /* + * Initialize functions(or definitions) that are different + * between vendors here. + */ + rdt_init_res_defs(); + /* Run quirks first */ rdt_quirks(); =20 diff --git a/arch/x86/kernel/cpu/resctrl.h b/arch/x86/kernel/cpu/resctrl.h index e5f7bf6a8d09..8731b7c91c28 100644 --- a/arch/x86/kernel/cpu/resctrl.h +++ b/arch/x86/kernel/cpu/resctrl.h @@ -444,8 +444,8 @@ struct rdt_resource { =20 int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r, struct rdt_domain *d); -int parse_bw(struct rdt_parse_data *data, struct rdt_resource *r, - struct rdt_domain *d); +int parse_bw_intel(struct rdt_parse_data *data, struct rdt_resource *r, + struct rdt_domain *d); =20 extern struct mutex rdtgroup_mutex; =20 @@ -468,6 +468,10 @@ enum { RDT_NUM_RESOURCES, }; =20 +#define for_each_rdt_resource(r) \ + for (r =3D rdt_resources_all; r < rdt_resources_all + RDT_NUM_RESOURCES;\ + r++) + #define for_each_capable_rdt_resource(r) \ for (r =3D rdt_resources_all; r < rdt_resources_all + RDT_NUM_RESOURCES;\ r++) \ diff --git a/arch/x86/kernel/cpu/resctrl_ctrlmondata.c b/arch/x86/kernel/cp= u/resctrl_ctrlmondata.c index e8d21306d0f9..78089ae8683c 100644 --- a/arch/x86/kernel/cpu/resctrl_ctrlmondata.c +++ b/arch/x86/kernel/cpu/resctrl_ctrlmondata.c @@ -64,8 +64,8 @@ static bool bw_validate(char *buf, unsigned long *data, s= truct rdt_resource *r) return true; } =20 -int parse_bw(struct rdt_parse_data *data, struct rdt_resource *r, - struct rdt_domain *d) +int parse_bw_intel(struct rdt_parse_data *data, struct rdt_resource *r, + struct rdt_domain *d) { unsigned long bw_val; =20 --=20 2.17.1