From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 02C1B7D089 for ; Mon, 12 Nov 2018 19:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729553AbeKMFkt (ORCPT ); Tue, 13 Nov 2018 00:40:49 -0500 Received: from mail.skyhub.de ([5.9.137.197]:56688 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725749AbeKMFkt (ORCPT ); Tue, 13 Nov 2018 00:40:49 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Xnd2I_qq2v-Z; Mon, 12 Nov 2018 20:46:07 +0100 (CET) Received: from zn.tnic (p200300EC2BE56F00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2be5:6f00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 218CF1EC03EA; Mon, 12 Nov 2018 20:46:07 +0100 (CET) Date: Mon, 12 Nov 2018 20:46:00 +0100 From: Borislav Petkov To: "Moger, Babu" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "reinette.chatre@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v7 02/13] arch/x86: Rename the RDT functions and definitions Message-ID: <20181112194600.GJ8167@zn.tnic> References: <20181109205153.14811-1-babu.moger@amd.com> <20181109205153.14811-3-babu.moger@amd.com> <20181112175610.GI8167@zn.tnic> <539bf8ea-b13f-186a-f1c7-71b1eaa63aa7@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <539bf8ea-b13f-186a-f1c7-71b1eaa63aa7@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Nov 12, 2018 at 07:25:02PM +0000, Moger, Babu wrote: > >> @@ -637,10 +637,11 @@ int rdt_get_mon_l3_config(struct rdt_resource *r) > >> * > >> * For a 35MB LLC and 56 RMIDs, this is ~1.8% of the LLC. > >> */ > >> - intel_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 / r->num_rmid; > >> + resctrl_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 / > >> + r->num_rmid; > > > > No need to break that line here. > > Without the line break, checkpatch complains for "line over 80 > characters". Do you think we can ignore those? To quote from the tip handbook which is in preparation right now: "+The 80 character rule is not a strict rule, so please use common sense when +breaking lines." In this particular case, it is more readable IMO to leave the line unbroken: resctrl_cqm_threshold = boot_cpu_data.x86_cache_size * 1024 / r->num_rmid; What is even more readable though is: unsigned int cl_size = boot_cpu_data.x86_cache_size; ... resctrl_cqm_threshold = cl_size * 1024 / r->num_rmid; and now you have a win-win situation. :) Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.