From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 3E91D7D08A for ; Thu, 15 Nov 2018 23:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725948AbeKPJKh (ORCPT ); Fri, 16 Nov 2018 04:10:37 -0500 Received: from mail.bootlin.com ([62.4.15.54]:59465 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbeKPJKh (ORCPT ); Fri, 16 Nov 2018 04:10:37 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 0DE62207BD; Fri, 16 Nov 2018 00:00:45 +0100 (CET) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 5EF9E2072C; Fri, 16 Nov 2018 00:00:44 +0100 (CET) Date: Fri, 16 Nov 2018 00:00:43 +0100 From: Boris Brezillon To: Fernando Ramos Cc: dri-devel@lists.freedesktop.org, David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , Jonathan Corbet , Alexey Brodkin , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Gerd Hoffmann , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Lucas Stach , Russell King , Christian Gmeiner , Marek Vasut , Stefan Agner , Kieran Bingham , Linus Walleij , Shawn Guo , Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , Haneen Mohammed , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, etnaviv@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put" Message-ID: <20181116000043.3b0f6f27@bbrezillon> In-Reply-To: <20181115221634.22715-4-greenfoo@gluegarage.com> References: <20181115221634.22715-1-greenfoo@gluegarage.com> <20181115221634.22715-4-greenfoo@gluegarage.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 15 Nov 2018 23:16:23 +0100 Fernando Ramos wrote: > This patch unifies the naming of DRM functions for reference counting as > requested on Documentation/gpu/todo.rst > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- For the Atmel HLCDC driver Acked-by: Boris Brezillon > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++-- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++-- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > drivers/gpu/drm/tve200/tve200_drv.c | 4 ++-- > drivers/gpu/drm/zte/zx_drm_drv.c | 4 ++-- > 8 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c > index f067de4e1e82..dcb06d4e9135 100644 > --- a/drivers/gpu/drm/arc/arcpgu_drv.c > +++ b/drivers/gpu/drm/arc/arcpgu_drv.c > @@ -216,7 +216,7 @@ static int arcpgu_probe(struct platform_device *pdev) > arcpgu_unload(drm); > > err_unref: > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -227,7 +227,7 @@ static int arcpgu_remove(struct platform_device *pdev) > > drm_dev_unregister(drm); > arcpgu_unload(drm); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return 0; > } > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 843cac222e60..f8da51a63e2f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -775,7 +775,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) > atmel_hlcdc_dc_unload(ddev); > > err_unref: > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return ret; > } > @@ -786,7 +786,7 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) > > drm_dev_unregister(ddev); > atmel_hlcdc_dc_unload(ddev); > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return 0; > } > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index 83c1f46670bf..52802e6049e0 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -550,7 +550,7 @@ static int etnaviv_bind(struct device *dev) > out_bind: > kfree(priv); > out_unref: > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) > drm->dev_private = NULL; > kfree(priv); > > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops etnaviv_master_ops = { > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 2393e6d16ffd..88ba003979e6 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -417,7 +417,7 @@ static int mxsfb_probe(struct platform_device *pdev) > err_unload: > mxsfb_unload(drm); > err_free: > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -428,7 +428,7 @@ static int mxsfb_remove(struct platform_device *pdev) > > drm_dev_unregister(drm); > mxsfb_unload(drm); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return 0; > } > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 084f58df4a8c..c7fe2433ab9e 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -454,7 +454,7 @@ static int rcar_du_remove(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return 0; > } > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > index 6ececad6f845..8554102a6ead 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > drm_irq_uninstall(ddev); > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return 0; > } > @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > err_free_drm_dev: > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return ret; > } > diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c > index 72efcecb44f7..28e2d03c0ccf 100644 > --- a/drivers/gpu/drm/tve200/tve200_drv.c > +++ b/drivers/gpu/drm/tve200/tve200_drv.c > @@ -249,7 +249,7 @@ static int tve200_probe(struct platform_device *pdev) > clk_disable: > clk_disable_unprepare(priv->pclk); > dev_unref: > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -263,7 +263,7 @@ static int tve200_remove(struct platform_device *pdev) > drm_panel_bridge_remove(priv->bridge); > drm_mode_config_cleanup(drm); > clk_disable_unprepare(priv->pclk); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return 0; > } > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c > index 11ef17c2d1c1..5b6f1eda52e0 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -114,7 +114,7 @@ static int zx_drm_bind(struct device *dev) > component_unbind_all(dev, drm); > out_unregister: > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -127,7 +127,7 @@ static void zx_drm_unbind(struct device *dev) > drm_mode_config_cleanup(drm); > component_unbind_all(dev, drm); > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops zx_drm_master_ops = {