linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: dev-tools: Fix typos in index.rst
@ 2018-11-22 15:34 Shreyans Devendra Doshi
  2018-11-22 21:01 ` Matthew Wilcox
  2018-11-25 19:28 ` Jonathan Corbet
  0 siblings, 2 replies; 4+ messages in thread
From: Shreyans Devendra Doshi @ 2018-11-22 15:34 UTC (permalink / raw)
  To: corbet; +Cc: linux-doc, linux-kernel, Shreyans Devendra Doshi

Fixes a spelling error and removes an extra whitespace character.

Signed-off-by: Shreyans Devendra Doshi <0xinfosect0r@gmail.com>
---
 Documentation/dev-tools/index.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/dev-tools/index.rst b/Documentation/dev-tools/index.rst
index e313925fb0fa..b0522a4dd107 100644
--- a/Documentation/dev-tools/index.rst
+++ b/Documentation/dev-tools/index.rst
@@ -3,8 +3,8 @@ Development tools for the kernel
 ================================
 
 This document is a collection of documents about development tools that can
-be used to work on the kernel.  For now, the documents have been pulled
-together without any significant effot to integrate them into a coherent
+be used to work on the kernel. For now, the documents have been pulled
+together without any significant effort to integrate them into a coherent
 whole; patches welcome!
 
 .. class:: toc-title
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: dev-tools: Fix typos in index.rst
  2018-11-22 15:34 [PATCH] Documentation: dev-tools: Fix typos in index.rst Shreyans Devendra Doshi
@ 2018-11-22 21:01 ` Matthew Wilcox
  2018-11-25 19:28 ` Jonathan Corbet
  1 sibling, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2018-11-22 21:01 UTC (permalink / raw)
  To: Shreyans Devendra Doshi; +Cc: corbet, linux-doc, linux-kernel

On Thu, Nov 22, 2018 at 10:34:56AM -0500, Shreyans Devendra Doshi wrote:
> Fixes a spelling error and removes an extra whitespace character.

There is a fierce battle amongst those who insist on one space after a
full stop and those who insist on two.  I recommend not getting caught
up in this battle, particularly since the point of this is to produce
html documentation and the amount of space displayed after a period is
then up to your web browser, not the source text.

I would not NACK this patch, since it does fix a typo, but please don't
send any more patches which adjust the number of whitespaces after a
full stop.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: dev-tools: Fix typos in index.rst
  2018-11-22 15:34 [PATCH] Documentation: dev-tools: Fix typos in index.rst Shreyans Devendra Doshi
  2018-11-22 21:01 ` Matthew Wilcox
@ 2018-11-25 19:28 ` Jonathan Corbet
  2018-11-25 19:36   ` Randy Dunlap
  1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2018-11-25 19:28 UTC (permalink / raw)
  To: Shreyans Devendra Doshi; +Cc: linux-doc, linux-kernel

On Thu, 22 Nov 2018 10:34:56 -0500
Shreyans Devendra Doshi <0xinfosect0r@gmail.com> wrote:

> Fixes a spelling error and removes an extra whitespace character.
> 
> Signed-off-by: Shreyans Devendra Doshi <0xinfosect0r@gmail.com>

I've applied this for the typo fix, but let me echo Willy's comments about
the whitespace change.  There is no official policy on spaces after
periods in kernel documentation, and I have no interest in adding one;
I'll not be accepting patches making such changes in the future.

Thanks,

jon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: dev-tools: Fix typos in index.rst
  2018-11-25 19:28 ` Jonathan Corbet
@ 2018-11-25 19:36   ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2018-11-25 19:36 UTC (permalink / raw)
  To: Jonathan Corbet, Shreyans Devendra Doshi; +Cc: linux-doc, linux-kernel

On 11/25/18 11:28 AM, Jonathan Corbet wrote:
> On Thu, 22 Nov 2018 10:34:56 -0500
> Shreyans Devendra Doshi <0xinfosect0r@gmail.com> wrote:
> 
>> Fixes a spelling error and removes an extra whitespace character.
>>
>> Signed-off-by: Shreyans Devendra Doshi <0xinfosect0r@gmail.com>
> 
> I've applied this for the typo fix, but let me echo Willy's comments about
> the whitespace change.  There is no official policy on spaces after
> periods in kernel documentation, and I have no interest in adding one;
> I'll not be accepting patches making such changes in the future.

Ack that.

thanks,
-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-25 19:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-22 15:34 [PATCH] Documentation: dev-tools: Fix typos in index.rst Shreyans Devendra Doshi
2018-11-22 21:01 ` Matthew Wilcox
2018-11-25 19:28 ` Jonathan Corbet
2018-11-25 19:36   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).