From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 1A6707D08A for ; Mon, 26 Nov 2018 22:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbeK0JXj (ORCPT ); Tue, 27 Nov 2018 04:23:39 -0500 Received: from mail.skyhub.de ([5.9.137.197]:56604 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbeK0JXi (ORCPT ); Tue, 27 Nov 2018 04:23:38 -0500 Received: from zn.tnic (p200300EC2BDEFE00DCA0409AA15535E1.dip0.t-ipconnect.de [IPv6:2003:ec:2bde:fe00:dca0:409a:a155:35e1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E15651EC04BC; Mon, 26 Nov 2018 23:28:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1543271281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=iVjDIULdAQcu4memzGX26FFlxh+bp76sTqwM3pVm0dk=; b=DS7SzMyvQkCTV3S9C52qlYqJ3ta0bT+BL0jkoAtkoEFHISfYcGOnyaDOLwY6euqa2dpOgl c0VobQL+RjoBRLmFn0OIudPMDA3NizJdMMWb0yBokc6YQdHrqd8vNLtR1cSIv73bDoQuBQ +XVkvl8uVx2x7y9AWE1ZG/NHgnOJ/pA= Date: Mon, 26 Nov 2018 23:28:00 +0100 From: Borislav Petkov To: Reinette Chatre Cc: "Moger, Babu" , "tglx@linutronix.de" , "mingo@redhat.com" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts Message-ID: <20181126222800.GR4843@zn.tnic> References: <20181121202811.4492-1-babu.moger@amd.com> <20181121202811.4492-11-babu.moger@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Nov 26, 2018 at 02:16:24PM -0800, Reinette Chatre wrote: > Hi Babu and Borislav, > > Two typos seemed to have slipped through into the merged commit ... > > On 11/21/2018 12:28 PM, Moger, Babu wrote: > > @@ -163,14 +163,14 @@ int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r, > > * either is exclusive. > > */ > > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, true)) { > > - rdt_last_cmd_printf("overlaps with exclusive group\n"); > > + rdt_last_cmd_printf("Overlaps with exclusive group\n"); > > return -EINVAL; > > } > > > > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, false)) { > > if (rdtgrp->mode == RDT_MODE_EXCLUSIVE || > > rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) { > > - rdt_last_cmd_printf("overlaps with other group\n"); > > + rdt_last_cmd_printf("0verlaps with other group\n"); > > return -EINVAL; > > } > > } > > There is a zero instead of O used in second "Overlaps". LOL! That's so l337 :-) > > @@ -1235,7 +1235,7 @@ static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of, > > goto out; > > rdtgrp->mode = RDT_MODE_PSEUDO_LOCKSETUP; > > } else { > > - rdt_last_cmd_printf("unknown/unsupported mode\n"); > > + rdt_last_cmd_printf("Unknown orunsupported mode\n"); > > ret = -EINVAL; > > } > > Missing a space. Whoops, nice catch. Can you send a fix pls? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.