From: Jonathan Corbet <corbet@lwn.net>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-doc@vger.kernel.org, kernel@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] configfs: fix wrong name of struct in documentation
Date: Thu, 20 Dec 2018 08:41:50 -0700 [thread overview]
Message-ID: <20181220084150.3075f8d7@lwn.net> (raw)
In-Reply-To: <20181207191158.18769-1-helen.koike@collabora.com>
On Fri, 7 Dec 2018 17:11:58 -0200
Helen Koike <helen.koike@collabora.com> wrote:
> The name of the struct is configfs_bin_attribute instead of
> configfs_attribute
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>
> ---
>
> Documentation/filesystems/configfs/configfs.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/configfs/configfs.txt b/Documentation/filesystems/configfs/configfs.txt
> index 3828e85345ae..16e606c11f40 100644
> --- a/Documentation/filesystems/configfs/configfs.txt
> +++ b/Documentation/filesystems/configfs/configfs.txt
> @@ -216,7 +216,7 @@ be called whenever userspace asks for a write(2) on the attribute.
>
> [struct configfs_bin_attribute]
>
> - struct configfs_attribute {
> + struct configfs_bin_attribute {
> struct configfs_attribute cb_attr;
> void *cb_private;
> size_t cb_max_size;
The document is clearly wrong, and this patch makes it better, so I've
applied it - thanks!
That said, the structure appears to have grown some fields that are not
reflected in the document; I suspect that there's much more in there that
is somewhat fictional at this point. Hopefully somebody someday can help
to fix it up.
Thanks,
jon
prev parent reply other threads:[~2018-12-20 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 19:11 [PATCH] configfs: fix wrong name of struct in documentation Helen Koike
2018-12-20 15:41 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220084150.3075f8d7@lwn.net \
--to=corbet@lwn.net \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).