linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, "Geyslan G . Bem" <geyslan@gmail.com>,
	Tiago Natel de Moura <tiago4orion@gmail.com>,
	Alison Chaiken <alison_chaiken@mentor.com>,
	Joe Perches <joe@perches.com>,
	Federico Vaga <federico.vaga@vaga.pv.it>,
	Zhang Le <r0bertz@gentoo.org>, Li Yang <leo@zh-kernel.org>
Subject: Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el
Date: Thu, 3 Jan 2019 18:12:21 -0800	[thread overview]
Message-ID: <20190104021221.GS6310@bombadil.infradead.org> (raw)
In-Reply-To: <20190104003957.82220-1-bvanassche@acm.org>

On Thu, Jan 03, 2019 at 04:39:57PM -0800, Bart Van Assche wrote:
> @@ -571,50 +571,11 @@ item, explaining its use.
>  9) You've made a mess of it
>  ---------------------------
>  
> -That's OK, we all do.  You've probably been told by your long-time Unix
> -user helper that ``GNU emacs`` automatically formats the C sources for
> -you, and you've noticed that yes, it does do that, but the defaults it
> -uses are less than desirable (in fact, they are worse than random
> -typing - an infinite number of monkeys typing into GNU emacs would never
> -make a good program).

I feel like this patch makes the mistake a lot of doc patches do ... it
removes some of the whimsical humourous comments that have been with
us for years.  I don't think this paragraph needs to be changed in
the slightest.

> -So, you can either get rid of GNU emacs, or change it to use saner
> -values.  To do the latter, you can stick the following in your .emacs file:
> -
[...]
> -
> -This will make emacs go better with the kernel coding style for C
> -files below ``~/src/linux-trees``.
> +``GNU emacs`` automatically formats the C sources for you. However,
> +the defaults it uses are less than desirable. Use a version of emacs
> +that support directory local variables such that it automatically
> +picks up the settings from .dir-locals.el in the kernel top level
> +directory.

How about:

So, you can either get rid of GNU emacs, or change it to use saner
defaults.  Versions of emacs since [...] support directory local
variables and will pick up the settings from .dir-locals.el in the
kernel top level directory.

  reply	other threads:[~2019-01-04  2:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04  0:39 [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el Bart Van Assche
2019-01-04  2:12 ` Matthew Wilcox [this message]
2019-01-04 16:06   ` Bart Van Assche
2019-01-04  9:44 ` Federico Vaga
2019-01-04 11:18   ` Jani Nikula
2019-01-04 16:40     ` Bart Van Assche
2019-01-07 10:29       ` Jani Nikula
2019-01-04 16:32   ` Bart Van Assche
2019-01-04 16:41     ` Jonathan Corbet
2019-01-04 18:26       ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2019-01-04 21:08 [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs Bart Van Assche
2019-01-04 21:08 ` [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el Bart Van Assche
2019-01-04 21:11   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104021221.GS6310@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=alison_chaiken@mentor.com \
    --cc=bvanassche@acm.org \
    --cc=corbet@lwn.net \
    --cc=federico.vaga@vaga.pv.it \
    --cc=geyslan@gmail.com \
    --cc=joe@perches.com \
    --cc=leo@zh-kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=r0bertz@gentoo.org \
    --cc=tiago4orion@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).