From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 462457D04D for ; Fri, 11 Jan 2019 16:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729740AbfAKQPa (ORCPT ); Fri, 11 Jan 2019 11:15:30 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36289 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728678AbfAKQPa (ORCPT ); Fri, 11 Jan 2019 11:15:30 -0500 Received: by mail-ot1-f65.google.com with SMTP id k98so13569497otk.3; Fri, 11 Jan 2019 08:15:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o2lJu0osneZBXtlcgr3qMVTvat7qTMs5SntOY5KyBr8=; b=iax4F2oFFFFZizjlivCr2RoOa4ZLpyIIzcJZRKP+3st84q4+D2kpUnbgnhKE6GaJqN 0ivZJHczxpt3RECQ08MOnHtbpjy22VrY6tpJJn/X20o6mS3nm95nPUCXHiC+imbElZEq 2gXJ6IvS0XXk7VlKXfMzlcqED4n3ZY/eEEt0eMrNvn3ihosgor+Vh0p2ZT/lI+EgZKLM KKAtkoPjVcRK+wiuhb9/ZwmQ4GOcFavN7csg7hPcYUlhErTkBjCkkaD1HM8+0wR67kwC rUe6oQnh0vWdyaccnen8kECtOL9WhwG5rhdqqkY4IgfebgdYEBI2Vi3QjOVfuQEP0kyk IzYQ== X-Gm-Message-State: AJcUukcO9qgxldihA5sZvuFUMmNLRCBce8C+DZyeUkfpbmT7LJeuvRBS oR9OjUkORRBafeRnq3Rhyw== X-Google-Smtp-Source: ALg8bN6Y7KgQBREz83gcFA7+qntf7qj6ajwNXPn9vaYxX2Kn4lDI6IOAKXi9O0qtS5d0RXp2fXQ3DQ== X-Received: by 2002:a9d:5f85:: with SMTP id g5mr10181558oti.333.1547223329316; Fri, 11 Jan 2019 08:15:29 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id q128sm37093019oia.4.2019.01.11.08.15.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 08:15:28 -0800 (PST) Date: Fri, 11 Jan 2019 10:15:27 -0600 From: Rob Herring To: "james qian wang (Arm Technology China)" Cc: Liviu Dudau , "daniel.vetter@ffwll.ch" , "rdunlap@infradead.org" , Mark Rutland , "linux-doc@vger.kernel.org" , "maxime.ripard@bootlin.com" , "Jonathan Chai (Arm Technology China)" , Alexandru-Cosmin Gheorghe , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "yamada.masahiro@socionext.com" , "Yiqi Kang (Arm Technology China)" , "mchehab+samsung@kernel.org" , "Tiannan Zhu (Arm Technology China)" , "corbet@lwn.net" , "airlied@linux.ie" , "malidp@foss.arm.com" , "thomas Sun (Arm Technology China)" , Ayan Halder , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "Jin Gao (Arm Technology China)" , nd , "sean@poorly.run" , "Lowry Li (Arm Technology China)" , "gregkh@linuxfoundation.org" , "nicolas.ferre@microchip.com" , "Julien Yin (Arm Technology China)" , "akpm@linux-foundation.org" , "davem@davemloft.net" Subject: Re: [PATCH v4 2/9] dt/bindings: drm/komeda: Add DT bindings for ARM display processor D71 Message-ID: <20190111161527.GA9669@bogus> References: <20190103113841.15403-1-james.qian.wang@arm.com> <20190103113841.15403-3-james.qian.wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190103113841.15403-3-james.qian.wang@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Jan 03, 2019 at 11:40:04AM +0000, james qian wang (Arm Technology China) wrote: > From: "james qian wang (Arm Technology China)" > > Add DT bindings documentation for the ARM display processor D71 and later > IPs. > > Changes in v4: > - Deleted unnecessary address-cells, size-cells [Liviu Dudau] > > Changes in v3: > - Deleted unnecessary property: interrupt-names. > - Dropped 'ports' and moving 'port' up a level. > > Signed-off-by: James Qian Wang (Arm Technology China) > Reviewed-by: Liviu Dudau > --- > .../bindings/display/arm/arm,komeda.txt | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/arm/arm,komeda.txt > > diff --git a/Documentation/devicetree/bindings/display/arm/arm,komeda.txt b/Documentation/devicetree/bindings/display/arm/arm,komeda.txt > new file mode 100644 > index 000000000000..919d651d3e8c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/arm/arm,komeda.txt > @@ -0,0 +1,73 @@ > +Device Tree bindings for Arm Komeda display driver > + > +Required properties: > +- compatible: Should be "arm,mali-d71" > +- reg: Physical base address and length of the registers in the system > +- interrupts: the interrupt line number of the device in the system > +- clocks: A list of phandle + clock-specifier pairs, one for each entry > + in 'clock-names' > +- clock-names: A list of clock names. It should contain: > + - "mclk": for the main processor clock > + - "pclk": for the APB interface clock > +- #address-cells: Must be 1 > +- #size-cells: Must be 0 > + > +Required properties for sub-node: pipeline@nq > +Each device contains one or two pipeline sub-nodes (at least one), each > +pipeline node should provide properties: > +- reg: Zero-indexed identifier for the pipeline > +- clocks: A list of phandle + clock-specifier pairs, one for each entry > + in 'clock-names' > +- clock-names: should contain: > + - "pxclk": pixel clock > + - "aclk": AXI interface clock > + > +- port: each pipeline connect to an encoder input port. The connection is > + modeled using the OF graph bindings specified in > + Documentation/devicetree/bindings/graph.txt > + > +Optional properties: > + - memory-region: phandle to a node describing memory (see > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt) > + to be used for the framebuffer; if not present, the framebuffer may > + be located anywhere in memory. > + > +Example: > +/ { > + ... > + > + dp0: display@c00000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "arm,mali-d71"; > + reg = <0xc00000 0x20000>; > + interrupts = <0 168 4>; > + clocks = <&dpu_mclk>, <&dpu_aclk>; > + clock-names = "mclk", "pclk"; > + > + dp0_pipe0: pipeline@0 { > + clocks = <&fpgaosc2>, <&dpu_aclk>; > + clock-names = "pxclk", "aclk"; > + reg = <0>; > + > + port@0 { Drop the '@0' > + dp0_pipe0_out: endpoint { > + remote-endpoint = <&db_dvi0_in>; > + }; > + }; > + }; > + > + dp0_pipe1: pipeline@1 { > + clocks = <&fpgaosc2>, <&dpu_aclk>; > + clock-names = "pxclk", "aclk"; > + reg = <1>; > + > + port@0 { And here. With that, Reviewed-by: Rob Herring > + dp0_pipe1_out: endpoint { > + remote-endpoint = <&db_dvi1_in>; > + }; > + }; > + }; > + }; > + ... > +}; > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel