From: Borislav Petkov <bp@alien8.de>
To: lijiang <lijiang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
akpm@linux-foundation.org, bhe@redhat.com, dyoung@redhat.com,
k-hagio@ab.jp.nec.com, anderson@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation
Date: Mon, 14 Jan 2019 10:10:14 +0100 [thread overview]
Message-ID: <20190114091014.GB2773@zn.tnic> (raw)
In-Reply-To: <93c1969f-dcc7-4e34-75ff-b14f2ec15269@redhat.com>
On Mon, Jan 14, 2019 at 09:52:14AM +0800, lijiang wrote:
> I would like to remove this variable and post again.
No, you should remove the vmcoreinfo export too:
kernel/crash_core.c:398: VMCOREINFO_OSRELEASE(init_uts_ns.name.release);
after making sure userspace is not using it and *then* remove the
documentation.
But you can do that in a separate patch, so that it can be reverted if
trouble.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-01-14 9:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:19 [PATCH 0/2 v6] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2019-01-10 12:19 ` [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation Lianbo Jiang
2019-01-11 12:33 ` Borislav Petkov
2019-01-14 1:52 ` lijiang
2019-01-14 9:10 ` Borislav Petkov [this message]
2019-01-14 17:48 ` Kazuhito Hagio
2019-01-14 18:01 ` Borislav Petkov
2019-01-14 18:58 ` Dave Anderson
2019-01-14 19:21 ` Borislav Petkov
2019-01-14 19:36 ` Dave Anderson
2019-01-14 19:59 ` Borislav Petkov
2019-01-14 20:07 ` Dave Anderson
2019-01-14 20:18 ` Borislav Petkov
2019-01-14 20:26 ` Dave Anderson
2019-01-14 20:35 ` Borislav Petkov
2019-01-14 20:49 ` Dave Anderson
2019-01-15 10:06 ` Borislav Petkov
2019-01-15 11:00 ` lijiang
2019-01-11 14:56 ` Borislav Petkov
2019-01-14 5:30 ` lijiang
2019-01-14 9:15 ` Borislav Petkov
2019-01-15 9:41 ` lijiang
2019-01-10 12:19 ` [PATCH 2/2 v6] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114091014.GB2773@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).