Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

lijiang
2019-01-15T09:41:31Z

在 2019年01月14日 17:15, Borislav Petkov 写道:
> On Mon, Jan 14, 2019 at 01:30:30PM +0800, lijiang wrote:
>> I noticed that the checkpatch was coded in Perl. But i am not familiar with
>> the Perl program language, that would be beyond my ability to do this, i have
>> to learn the Perl program language step by step. :-)
>
> You could give it a try - it is not hard :-)
>

Thank you for encouraging me to do the things.

> And there's no hurry for this, take your time.
>
OK. I would like to put this task in my queue. Once i have free time, i will work
on this issue.

>> Do you mean this one 'KERNEL_IMAGE_SIZE'?
>
> I mean, all those which are unused. Optimally, you should look at the
> tools and see whether they're using those exports and if not, remove
> them. But no hurry here too, take your time.
>
OK. I will check it again, But, basically they are used by Makedumpfile or Crash tools.

> My final goal is to have this up-to-date documentation of what is
> exported and what is used by user tools so that people can look at it
> first before carelessly exporting yet another thing.
>
Agree.

Thanks,
Lianbo
> Thx.
>