From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id D379A7D099 for ; Wed, 16 Jan 2019 22:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732123AbfAPWDJ (ORCPT ); Wed, 16 Jan 2019 17:03:09 -0500 Received: from ms.lwn.net ([45.79.88.28]:52652 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731870AbfAPWDI (ORCPT ); Wed, 16 Jan 2019 17:03:08 -0500 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 26BA5300; Wed, 16 Jan 2019 22:03:08 +0000 (UTC) Date: Wed, 16 Jan 2019 15:03:07 -0700 From: Jonathan Corbet To: Otto Sabart Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 1/3] doc: networking: prepare scaling document for conversion into RST Message-ID: <20190116150307.67eb2201@lwn.net> In-Reply-To: <9a37aecf3f7e5b0df579f4c72885b0716f5abd6c.1547063330.git.ottosabart@seberm.com> References: <9a37aecf3f7e5b0df579f4c72885b0716f5abd6c.1547063330.git.ottosabart@seberm.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 9 Jan 2019 20:57:22 +0100 Otto Sabart wrote: > Add markups which are necessary for successful conversion into > reStructuredText. > > There are no semantic changes. > > Signed-off-by: Otto Sabart This seems generally good, except: > Documentation/networking/scaling.txt | 131 +++++++++++++++++---------- > 1 file changed, 85 insertions(+), 46 deletions(-) > > diff --git a/Documentation/networking/scaling.txt b/Documentation/networking/scaling.txt > index b7056a8a0540..0ce13ed103bd 100644 > --- a/Documentation/networking/scaling.txt > +++ b/Documentation/networking/scaling.txt > @@ -1,4 +1,8 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +===================================== > Scaling in the Linux Networking Stack > +===================================== > > > Introduction > @@ -10,11 +14,11 @@ multi-processor systems. > > The following technologies are described: > > - RSS: Receive Side Scaling > - RPS: Receive Packet Steering > - RFS: Receive Flow Steering > - Accelerated Receive Flow Steering > - XPS: Transmit Packet Steering > +- RSS: Receive Side Scaling > +- RPS: Receive Packet Steering > +- RFS: Receive Flow Steering > +- Accelerated Receive Flow Steering > +- XPS: Transmit Packet Steering > > > RSS: Receive Side Scaling > @@ -45,7 +49,9 @@ programmable filters. For example, webserver bound TCP port 80 packets > can be directed to their own receive queue. Such “n-tuple” filters can > be configured from ethtool (--config-ntuple). > > -==== RSS Configuration > + > +RSS Configuration > +````````````````` The use of the heading levels is kind of strange; I'm not really sure why you did it that way? I'd rather this adhered to our normal hierarchy, so it should be: RSS Configuration ----------------- All of the other bottom-level headings should be as well. Fix that up, please, and I can take these. The whole series can also be squashed into a single patch (though I don't feel really strongly about that either way). Thanks, jon