From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 7B4417D099 for ; Mon, 28 Jan 2019 21:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbfA1VWL (ORCPT ); Mon, 28 Jan 2019 16:22:11 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:38136 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbfA1VWK (ORCPT ); Mon, 28 Jan 2019 16:22:10 -0500 Received: by mail-yb1-f194.google.com with SMTP id x9so7318966ybj.5 for ; Mon, 28 Jan 2019 13:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R1tczXKUFzCTDG0EEeYL9B/rEiyBaMRbEigEvPcalsM=; b=BWUNZDIv09sdTYAuXBiMqvx25t8xYdms70LlJhXdraVVD4ND8QZS1Egu8kl28LrAv4 2rsNe0xfjtXsa/7pAXDQX6XO7sQieqd+EoOUKyCtprrkAymp9xe1Aeo74Y3eoOJVKeVx I0w6f357EMaAsZhJCUprEfPEHCLSP0tmMJuLaozqSHfrax7T2Pd23uVXFhJM/TXo9Rtj PtLwtSrHs9eF41prnQYcst3HKBz6IZj/I4ryQ30PPfy07J7OPxoEMq7LNSjHJp/VE7vL sg4s3VlxembefLFtixuvyf9Ov0Z+CqLqVM1dYMADBiaWsKBM2idCLIzQtE30kWIsBQOi 9yig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R1tczXKUFzCTDG0EEeYL9B/rEiyBaMRbEigEvPcalsM=; b=UCDPCznYr4UdYxHF1FMVmht16pVKFHK1ZqJYt+zIukNBsF6VqcaLlzuuiDSTo8yzJx aa0TGSbn3NRw616MuJMTIHemzqgCAY1BBN0hR9cR1cwLaKxBHki/Kw+Mb+z7EhitbQWe RFYZ1B/FnJrNSixaToRKhJV1vOeR3gd7IRi5GFqREo/mG8WRzrLCngd3a6IEDNot59TD nt3FhT52zY+hrdcT547q6/wh+dX2l/OtIxqtJP3+OBEYPQiqaYVLktk7YAE3VH5FYUM9 T9yl8j2PHhevIZUc2rowPs4MzQwMLIWhxEViemVmfl4c0E+4c6r66VFUTP4pOe5ZjdFO 6xFA== X-Gm-Message-State: AJcUukcMB2EqdDRQ5nqkmZK4U0Og5PkfchgqCUJXHnKHYGvk7QHyoKR+ 1Kr1IJy6jbZDwLhE9xRnGcdb7Q== X-Google-Smtp-Source: ALg8bN67pMPbU43pXLl6O/DjG+0UAfhqYH7oETTn698WBm4AXKfHjyzns7FKkPi/tFPcEFuAgdI2CA== X-Received: by 2002:a25:cc04:: with SMTP id l4mr16091947ybf.50.1548710529969; Mon, 28 Jan 2019 13:22:09 -0800 (PST) Received: from localhost ([2620:10d:c091:200::5:42c8]) by smtp.gmail.com with ESMTPSA id i128sm13849151ywb.82.2019.01.28.13.22.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 13:22:09 -0800 (PST) Date: Mon, 28 Jan 2019 16:22:08 -0500 From: Johannes Weiner To: Suren Baghdasaryan Cc: gregkh@linuxfoundation.org, tj@kernel.org, lizefan@huawei.com, axboe@kernel.dk, dennis@kernel.org, dennisszhou@gmail.com, mingo@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 3/5] psi: introduce state_mask to represent stalled psi states Message-ID: <20190128212208.GA1416@cmpxchg.org> References: <20190124211518.244221-1-surenb@google.com> <20190124211518.244221-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124211518.244221-4-surenb@google.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Jan 24, 2019 at 01:15:16PM -0800, Suren Baghdasaryan wrote: > The psi monitoring patches will need to determine the same states as > record_times(). To avoid calculating them twice, maintain a state mask > that can be consulted cheaply. Do this in a separate patch to keep the > churn in the main feature patch at a minimum. > This adds 4-byte state_mask member into psi_group_cpu struct which > results in its first cacheline-aligned part to become 52 bytes long. > Add explicit values to enumeration element counters that affect > psi_group_cpu struct size. > > Signed-off-by: Suren Baghdasaryan Acked-by: Johannes Weiner