From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id C43827D04D for ; Wed, 30 Jan 2019 16:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730902AbfA3QHK (ORCPT ); Wed, 30 Jan 2019 11:07:10 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35770 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728943AbfA3QHK (ORCPT ); Wed, 30 Jan 2019 11:07:10 -0500 Received: by mail-ot1-f65.google.com with SMTP id 81so65182otj.2; Wed, 30 Jan 2019 08:07:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g2YVABEOYLcMlUm2t8Parde08+vXwjS1kxc3IjzVaM0=; b=bhyZi95r+mp/XCQTSZGbwIP2iJGv++ReOo7Yr+eDDX/cQcgW+HicDXAtJkTdZOM4Kw H2ByyReUihGsCmmIyfS5PDj+NQYKKzS5mHHYHWmiY/bMP4+Z2Zk1ew1m5LBduqrG5GBy Sm8zM0m7E2H/XLLifx+NFVoz59JP4pkSJzgqLPriIgQUwomBUXvzYLtlyfY56TfnjVbT iYjmXym+DQjxAzIkF/vk72Vd/Ia2QCpF01Pt8e8aEsP2quJFw+BFlNWmGjWmiO8mHMSz eek4UosvbSNk2oV3w4aYyAoq4MKb6lPh2fekNt3w/8Rki73x1RfFY5W2SZg8Kse3FFNv FmSw== X-Gm-Message-State: AJcUukdEWvKV5uwBjwvmIuobIWI+SWHo1WFvXQY2s6JF1t6mVQGNHteU /vFXKlH72FmdcUONHY7LMULa0BY= X-Google-Smtp-Source: ALg8bN61w4RcI3Wx58qjC+ljn2ByYOU452ZYGnsKTzGjhCHLAAxMV4BeuKBMSKz6ck77BF2PuDSEdg== X-Received: by 2002:a9d:2184:: with SMTP id s4mr24453896otb.46.1548864429221; Wed, 30 Jan 2019 08:07:09 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 102sm668062otj.65.2019.01.30.08.07.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 08:07:08 -0800 (PST) Date: Wed, 30 Jan 2019 10:07:07 -0600 From: Rob Herring To: liaoweixiong Cc: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Mark Rutland , Mauro Carvalho Chehab , Greg Kroah-Hartman , "David S. Miller" , Andrew Morton , Nicolas Ferre , Arnd Bergmann , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC v7 2/5] dt-bindings: pstore-block: new support for blkoops Message-ID: <20190130160707.GA31844@bogus> References: <1548245116-6360-1-git-send-email-liaoweixiong@allwinnertech.com> <1548245116-6360-3-git-send-email-liaoweixiong@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548245116-6360-3-git-send-email-liaoweixiong@allwinnertech.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Jan 23, 2019 at 08:05:13PM +0800, liaoweixiong wrote: > Create DT binding document for blkoops. > > Signed-off-by: liaoweixiong > --- > .../devicetree/bindings/pstore-block/blkoops.txt | 32 ++++++++++++++++++++++ /bindings/pstore/... I wouldn't call it blkoops either. I believe ramoops is called that to maintain compatibility keeping the same kernel module name that preceeded pstore. > MAINTAINERS | 1 + > 2 files changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pstore-block/blkoops.txt > > diff --git a/Documentation/devicetree/bindings/pstore-block/blkoops.txt b/Documentation/devicetree/bindings/pstore-block/blkoops.txt > new file mode 100644 > index 0000000..a25835b > --- /dev/null > +++ b/Documentation/devicetree/bindings/pstore-block/blkoops.txt > @@ -0,0 +1,32 @@ > +Blkoops oops logger > +=================== > + > +Blkoops provides a block partition for oops, excluding panics now, so they can > +be recovered after a reboot. > + > +Any space of block partition will be used for a circular buffer of oops records. > +These records have a configurable size, with a size of 0 indicating that they > +should be disabled. > + > +"partition-size" and at least one of "dmesg-size" or "pmsg-size" must be set > +non-zero, but are otherwise optional as listed below. > + > +Blkoops will take value from Kconfig if device tree do not set, but settings > +from module parameters can also overwrite them. That's all kernel details not relevant to the binidng. > + > +Required properties: > + > +- compatible: must be "blkoops". > + > +- partition-size: size in kbytes, must be a multiple of 4. This seems unnecessary given a partition has a known size. > + > +Optional properties: > + > +- partition-path: strings must begin with "/dev", tell blkoops which partition > + it can used. If it is not set, blkoops will drop all data when reboot. No. '/dev/...' is a Linux thing and doesn't belong in DT. You should define a partition UUID and/or label and the kernel can find the right partition to use. > + > +- dmesg-size: maximum size in kbytes of each dump done on oops, which must be a > + multiple of 4. > + > +- pmsg-size: maximum size in kbytes for userspace messages, which must be a > + multiple of 4. Common properties shared with ramoops should be in a common doc. Rob