From: Jonathan Corbet <corbet@lwn.net>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
"Tobin C. Harding" <tobin@kernel.org>,
Christopher Lameter <cl@linux.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/3] docs: Use underscore not hyphen in label
Date: Fri, 1 Feb 2019 16:03:10 -0700 [thread overview]
Message-ID: <20190201160310.5b98eb69@lwn.net> (raw)
In-Reply-To: <20190131205608.GB1329@eros.localdomain>
On Fri, 1 Feb 2019 07:56:08 +1100
"Tobin C. Harding" <me@tobin.cc> wrote:
> > > From: "Tobin C. Harding" <tobin@kernel.org>
> > >
> > > sphinx emits warning
> > >
> > > WARNING: undefined label: memory-allocation ...
> >
> > Weird, for me it works fine. The generated html at kernel.org [1] also
> > seems to be Ok...
> >
> > What version of sphinx do you use?
>
> Thanks for looking at this Mike. I was running 1.4, I see there is a v2
> out so I'll upgrade but if the warning doesn't show for you then I'd say
> we just drop this patch.
>
> Jon,
>
> Is it within your usual workflow to take just the first two patches from
> this series or would you like me to spin another version without the
> final patch in it?
We currently document that 1.4 is supposed to work, so we should stick to
that; I think I'll go ahead and apply all three patches.
We should maybe consider dragging our minimum version forward a bit, or
else we might want to document this particular gotcha.
Thanks,
jon
next prev parent reply other threads:[~2019-02-01 23:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 4:06 [PATCH 0/3] docs: vm: Fix typo and build warnings Tobin C. Harding
2019-01-31 4:06 ` [PATCH 1/3] docs: Fix SLUB docs typo Tobin C. Harding
2019-01-31 9:30 ` Mike Rapoport
2019-01-31 4:06 ` [PATCH 2/3] docs: Add missing colon Tobin C. Harding
2019-01-31 9:30 ` Mike Rapoport
2019-01-31 4:06 ` [PATCH 3/3] docs: Use underscore not hyphen in label Tobin C. Harding
2019-01-31 9:27 ` Mike Rapoport
2019-01-31 20:56 ` Tobin C. Harding
2019-02-01 23:03 ` Jonathan Corbet [this message]
2019-02-02 14:32 ` Mike Rapoport
2019-02-03 23:20 ` Tobin C. Harding
2019-02-04 8:38 ` Mike Rapoport
2019-02-04 21:12 ` Tobin C. Harding
2019-02-04 23:03 ` Jonathan Corbet
2019-02-05 8:30 ` Markus Heiser
2019-02-06 4:27 ` Tobin C. Harding
2019-02-06 7:49 ` Markus Heiser
2019-02-06 20:28 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201160310.5b98eb69@lwn.net \
--to=corbet@lwn.net \
--cc=cl@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=me@tobin.cc \
--cc=rppt@linux.ibm.com \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).