From: Sasha Levin <sashal@kernel.org>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Babu Moger <Babu.Moger@amd.com>, Borislav Petkov <bp@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Brijesh Singh <brijesh.singh@amd.com>,
"Chang S. Bae" <chang.seok.bae@intel.com>,
David Miller <davem@davemloft.net>,
David Woodhouse <dwmw2@infradead.org>,
Dmitry Safonov <dima@arista.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jann Horn <jannh@google.com>, Joerg Roedel <jroedel@suse.de>,
Jonathan Corbet <corbet@lwn.net>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-doc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Pu Wen <puwen@hygon.cn>,
qianyue.zj@alibaba-inc.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rian Hunter <rian@alum.mit.edu>,
Sherry Hurwitz <sherry.hurwitz@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Tony Luck <tony.luck@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
xiaochen.shen@intel.com
Subject: Re: [PATCH AUTOSEL 4.19 059/258] x86/resctrl: Fixup the user-visible strings
Date: Sat, 2 Feb 2019 14:30:50 -0500 [thread overview]
Message-ID: <20190202193050.GA3973@sasha-vm> (raw)
In-Reply-To: <c9c45e03-aef3-e1be-2c81-d903a1669499@intel.com>
On Mon, Jan 28, 2019 at 11:07:34AM -0800, Reinette Chatre wrote:
>Hi Sasha,
>
>On 1/28/2019 7:56 AM, Sasha Levin wrote:
>> From: Babu Moger <Babu.Moger@amd.com>
>>
>> [ Upstream commit 723f1a0dd8e26a7523ba068204bee11c95ded38d ]
>>
>> Fix the messages in rdt_last_cmd_printf() and rdt_last_cmd_puts() to
>> make them more meaningful and consistent.
>
>It is not clear to me why this patch is considered for stable since it
>just changes user visible strings to be more consistent.
>
>If user visible string consistency/correctness is of concern and is what
>prompted its consideration then please also consider to include upstream
>commit
>456824896de2b68df40b3ea5777ef49dc6cc8fda "x86/resctrl: Use
>rdt_last_cmd_puts() where possible" that fixes two typos that was
>introduced in this commit. This may introduce difficultly though since
>the file layout changed between the kernel versions these patches are
>found in.
I've dropped it, it shouldn't have been included to begin with.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-02-02 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190128155924.51521-1-sashal@kernel.org>
2019-01-28 15:56 ` [PATCH AUTOSEL 4.19 059/258] x86/resctrl: Fixup the user-visible strings Sasha Levin
2019-01-28 19:07 ` Reinette Chatre
2019-02-02 19:30 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202193050.GA3973@sasha-vm \
--to=sashal@kernel.org \
--cc=Babu.Moger@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=chang.seok.bae@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=puwen@hygon.cn \
--cc=qianyue.zj@alibaba-inc.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=rian@alum.mit.edu \
--cc=sherry.hurwitz@amd.com \
--cc=stable@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox