From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] x86/fpu: Parse comma separated list passed in clearcpuid
Date: Thu, 21 Feb 2019 10:58:06 -0800 [thread overview]
Message-ID: <20190221185806.GC16922@tassilo.jf.intel.com> (raw)
In-Reply-To: <20190221133745.GP32494@hirez.programming.kicks-ass.net>
On Thu, Feb 21, 2019 at 02:37:45PM +0100, Peter Zijlstra wrote:
> On Thu, Feb 21, 2019 at 08:12:25AM -0500, Prarit Bhargava wrote:
> > Users cannot disable multiple CPU features with the kernel parameter
> > clearcpuid=. For example, "clearcpuid=154 clearcpuid=227" only disables
> > CPUID bit 154.
> >
> > Previous to commit 0c2a3913d6f5 ("x86/fpu: Parse clearcpuid= as early XSAVE
> > argument") it was possible to pass multiple clearcpuid options as kernel
> > parameters using individual entries. With the new code it isn't easy to
> > replicate exactly that behaviour but a comma separated list can be easily
> > implemented, eg) "clearcpuid=154,227"
> >
> > Make the clearcpuid parse a comma-separated list of values instead of only
> > a single value.
>
> So I think the feature is broken as is; because it doesn't clear the
> CPUID bits for userspace.
Usually it's enough to make the kernel stop using something. I used it many
times for this.
People who want to affect user space usually run VMs anyways.
-Andi
next prev parent reply other threads:[~2019-02-21 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 13:12 [PATCH] x86/fpu: Parse comma separated list passed in clearcpuid Prarit Bhargava
2019-02-21 13:37 ` Peter Zijlstra
2019-02-21 18:58 ` Andi Kleen [this message]
2019-02-21 19:01 ` Prarit Bhargava
2019-02-21 13:48 ` Peter Zijlstra
2019-02-27 23:48 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221185806.GC16922@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox