linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <tobin@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/9] docs: Fix various build warnings/errors
Date: Fri,  8 Mar 2019 08:11:44 +1100	[thread overview]
Message-ID: <20190307211153.28400-1-tobin@kernel.org> (raw)

Hi,

I had a few hours to spare so I thought I'd clear some Sphinx build
warnings/errors.  There isn't anything too controversial here.  The only
interesting thing I hit was in patch 7 (docs: Remove unknown 'hint'
directive), I couldn't work out if this was a serious directive, a joke,
or a typo.  Please review that patch more carefully than the others.

Patch 4 adds :ref: and raises an issue I've come across a few times now,
could I have your opinion on it please (if you have the time/inclination
to share it)

:ref:`/Documentation/path/to/file.rst <label>`

vs

:ref:`label`

Undeniably the second is better in HTML.  The first is, on one hand,
arguable better to parse when reading the textual file (since you can
see which file it refers to) but on the other hand kinda looks ugly
since it often line wraps poorly and is a bit cluttered if all you want to
see is the path.  Having only the label doesn't _really_ make it worse
in text because often you already know (or don't care) what the path is
(e.g. when there are multiple refs to the same label) and if you do care
you can just grep the docs for the label.

Do you have an opinion on this?

Oh also, do you have a script by any chance that does a clean build of
the docs, saves stderr output, applies a patch, cleanly re-builds the
docs and then diffs the two outputs?  Then rinse-and-repeat for a whole
patch series. Thought I'd ask before I write one.

thanks,
Tobin.

Tobin C. Harding (9):
  docs: Fix spelling mistake
  docs: Add colon clearing sphinx warning
  docs: Remove unnecessary reference link title
  docs: Use reference to link to rst file
  docs: Replace backtick with apostrophe.
  docs: Use correct list markup character
  docs: Remove unknown 'hint' directive
  docs: Fix Title underline too short warning
  docs: Add blank line after SPDX licence identifier

 .../admin-guide/mm/numa_memory_policy.rst     |  9 ++-
 .../driver-api/dmaengine/dmatest.rst          |  4 +-
 Documentation/driver-api/gpio/board.rst       |  5 +-
 Documentation/filesystems/path-lookup.rst     | 24 ++++----
 Documentation/laptops/lg-laptop.rst           | 13 +++--
 Documentation/misc-devices/ibmvmc.rst         |  1 +
 Documentation/networking/snmp_counter.rst     | 58 +++++++++----------
 Documentation/process/howto.rst               |  2 +-
 Documentation/vm/numa.rst                     |  4 +-
 Documentation/vm/slub.rst                     |  2 +-
 include/linux/kernel.h                        |  2 +-
 include/linux/wait.h                          |  2 +-
 12 files changed, 64 insertions(+), 62 deletions(-)

-- 
2.21.0


             reply	other threads:[~2019-03-07 21:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 21:11 Tobin C. Harding [this message]
2019-03-07 21:11 ` [PATCH 1/9] docs: Fix spelling mistake Tobin C. Harding
2019-03-07 21:11 ` [PATCH 2/9] docs: Add colon clearing sphinx warning Tobin C. Harding
2019-03-07 21:11 ` [PATCH 3/9] docs: Remove unnecessary reference link title Tobin C. Harding
2019-03-07 21:11 ` [PATCH 4/9] docs: Use reference to link to rst file Tobin C. Harding
2019-03-07 21:11 ` [PATCH 5/9] docs: Replace backtick with apostrophe Tobin C. Harding
2019-03-08  3:35   ` Randy Dunlap
2019-03-07 21:11 ` [PATCH 6/9] docs: Use correct list markup character Tobin C. Harding
2019-03-08  3:40   ` Randy Dunlap
2019-03-08  4:58     ` Tobin C. Harding
2019-03-07 21:11 ` [PATCH 7/9] docs: Remove unknown 'hint' directive Tobin C. Harding
2019-03-08  3:51   ` Randy Dunlap
2019-03-08  8:27     ` Markus Heiser
2019-03-08 16:04       ` Randy Dunlap
2019-03-08 16:35         ` Randy Dunlap
2019-03-07 21:11 ` [PATCH 8/9] docs: Fix Title underline too short warning Tobin C. Harding
2019-03-08  3:42   ` Randy Dunlap
2019-03-08  4:57     ` Tobin C. Harding
2019-03-07 21:11 ` [PATCH 9/9] docs: Add blank line after SPDX licence identifier Tobin C. Harding
2019-03-08  3:43   ` Randy Dunlap
2019-03-08  8:40 ` [PATCH 0/9] docs: Fix various build warnings/errors Markus Heiser
2019-03-08 20:16   ` Tobin C. Harding
2019-03-09  9:20     ` Markus Heiser
2019-03-25 16:33 ` Jonathan Corbet
2019-03-25 21:59   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307211153.28400-1-tobin@kernel.org \
    --to=tobin@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).