From: Jonathan Corbet <corbet@lwn.net>
To: Tom Levy <tomlevy93@gmail.com>
Cc: linux-doc@vger.kernel.org, Trivial Patch Monkey <trivial@kernel.org>
Subject: Re: [PATCH] docs: remove spaces from shell variable assignment
Date: Mon, 25 Mar 2019 09:53:50 -0600 [thread overview]
Message-ID: <20190325095350.076478c1@lwn.net> (raw)
In-Reply-To: <20190321013756.13028-1-tomlevy93@gmail.com>
On Thu, 21 Mar 2019 14:37:56 +1300
Tom Levy <tomlevy93@gmail.com> wrote:
> The instructions for generating patches are given as shell commands
> with variables as placeholders. They use the syntax "SRCTREE= linux",
> which is wrong for the Bourne shell family (it runs the command
> "linux" with the variable "SRCTREE" set to the empty string).
>
> Remove the spaces to avoid confusion. This breaks the pretty alignment
> but helps new contributors who try to run the commands as written.
>
> Signed-off-by: Tom Levy <tomlevy93@gmail.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
Applied, thanks. Though I agree with Jani that this advice is looking a
little dated in general...
jon
prev parent reply other threads:[~2019-03-25 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 1:37 [PATCH] docs: remove spaces from shell variable assignment Tom Levy
2019-03-21 13:36 ` Jani Nikula
2019-03-25 15:53 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325095350.076478c1@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=tomlevy93@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).