* [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions [not found] <20190326230011.GA16275@linux.ibm.com> @ 2019-03-26 23:00 ` Paul E. McKenney 2019-03-27 3:21 ` Masami Hiramatsu 0 siblings, 1 reply; 3+ messages in thread From: Paul E. McKenney @ 2019-03-26 23:00 UTC (permalink / raw) To: rcu Cc: linux-kernel, mingo, jiangshanlai, dipankar, akpm, mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells, edumazet, fweisbec, oleg, joel, Paul E. McKenney, Naveen N. Rao, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, Jonathan Corbet, linux-doc The RCU flavors have been consolidated, so this commit replaces mentions of the now-obsolete synchronize_sched() function with synchronize_rcu(). Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com> Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Jonathan Corbet <corbet@lwn.net> Cc: <linux-doc@vger.kernel.org> --- Documentation/kprobes.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt index 10f4499e677c..ee60e519438a 100644 --- a/Documentation/kprobes.txt +++ b/Documentation/kprobes.txt @@ -243,10 +243,10 @@ Optimization ^^^^^^^^^^^^ The Kprobe-optimizer doesn't insert the jump instruction immediately; -rather, it calls synchronize_sched() for safety first, because it's +rather, it calls synchronize_rcu() for safety first, because it's possible for a CPU to be interrupted in the middle of executing the -optimized region [3]_. As you know, synchronize_sched() can ensure -that all interruptions that were active when synchronize_sched() +optimized region [3]_. As you know, synchronize_rcu() can ensure +that all interruptions that were active when synchronize_rcu() was called are done, but only if CONFIG_PREEMPT=n. So, this version of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_. -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions 2019-03-26 23:00 ` [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions Paul E. McKenney @ 2019-03-27 3:21 ` Masami Hiramatsu 2019-03-27 20:22 ` Paul E. McKenney 0 siblings, 1 reply; 3+ messages in thread From: Masami Hiramatsu @ 2019-03-27 3:21 UTC (permalink / raw) To: Paul E. McKenney Cc: rcu, linux-kernel, mingo, jiangshanlai, dipankar, akpm, mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells, edumazet, fweisbec, oleg, joel, Naveen N. Rao, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, Jonathan Corbet, linux-doc On Tue, 26 Mar 2019 16:00:49 -0700 "Paul E. McKenney" <paulmck@linux.ibm.com> wrote: > The RCU flavors have been consolidated, so this commit replaces mentions > of the now-obsolete synchronize_sched() function with synchronize_rcu(). Thank you for updating! Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > > Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com> > Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com> > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: <linux-doc@vger.kernel.org> > --- > Documentation/kprobes.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt > index 10f4499e677c..ee60e519438a 100644 > --- a/Documentation/kprobes.txt > +++ b/Documentation/kprobes.txt > @@ -243,10 +243,10 @@ Optimization > ^^^^^^^^^^^^ > > The Kprobe-optimizer doesn't insert the jump instruction immediately; > -rather, it calls synchronize_sched() for safety first, because it's > +rather, it calls synchronize_rcu() for safety first, because it's > possible for a CPU to be interrupted in the middle of executing the > -optimized region [3]_. As you know, synchronize_sched() can ensure > -that all interruptions that were active when synchronize_sched() > +optimized region [3]_. As you know, synchronize_rcu() can ensure > +that all interruptions that were active when synchronize_rcu() > was called are done, but only if CONFIG_PREEMPT=n. So, this version > of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_. > > -- > 2.17.1 > -- Masami Hiramatsu <mhiramat@kernel.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions 2019-03-27 3:21 ` Masami Hiramatsu @ 2019-03-27 20:22 ` Paul E. McKenney 0 siblings, 0 replies; 3+ messages in thread From: Paul E. McKenney @ 2019-03-27 20:22 UTC (permalink / raw) To: Masami Hiramatsu Cc: rcu, linux-kernel, mingo, jiangshanlai, dipankar, akpm, mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells, edumazet, fweisbec, oleg, joel, Naveen N. Rao, Anil S Keshavamurthy, David S. Miller, Jonathan Corbet, linux-doc On Wed, Mar 27, 2019 at 12:21:12PM +0900, Masami Hiramatsu wrote: > On Tue, 26 Mar 2019 16:00:49 -0700 > "Paul E. McKenney" <paulmck@linux.ibm.com> wrote: > > > The RCU flavors have been consolidated, so this commit replaces mentions > > of the now-obsolete synchronize_sched() function with synchronize_rcu(). > > Thank you for updating! > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Applied, thank you! Thanx, Paul > > Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com> > > Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com> > > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Masami Hiramatsu <mhiramat@kernel.org> > > Cc: Jonathan Corbet <corbet@lwn.net> > > Cc: <linux-doc@vger.kernel.org> > > --- > > Documentation/kprobes.txt | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt > > index 10f4499e677c..ee60e519438a 100644 > > --- a/Documentation/kprobes.txt > > +++ b/Documentation/kprobes.txt > > @@ -243,10 +243,10 @@ Optimization > > ^^^^^^^^^^^^ > > > > The Kprobe-optimizer doesn't insert the jump instruction immediately; > > -rather, it calls synchronize_sched() for safety first, because it's > > +rather, it calls synchronize_rcu() for safety first, because it's > > possible for a CPU to be interrupted in the middle of executing the > > -optimized region [3]_. As you know, synchronize_sched() can ensure > > -that all interruptions that were active when synchronize_sched() > > +optimized region [3]_. As you know, synchronize_rcu() can ensure > > +that all interruptions that were active when synchronize_rcu() > > was called are done, but only if CONFIG_PREEMPT=n. So, this version > > of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_. > > > > -- > > 2.17.1 > > > > > -- > Masami Hiramatsu <mhiramat@kernel.org> > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-27 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190326230011.GA16275@linux.ibm.com>
2019-03-26 23:00 ` [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions Paul E. McKenney
2019-03-27 3:21 ` Masami Hiramatsu
2019-03-27 20:22 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).