From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 5E3297D04D for ; Mon, 15 Apr 2019 08:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725816AbfDOIss (ORCPT ); Mon, 15 Apr 2019 04:48:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:32832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbfDOIsr (ORCPT ); Mon, 15 Apr 2019 04:48:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B716F20693; Mon, 15 Apr 2019 08:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555318127; bh=XqWBP5IDXjWbx5vkOZWZaSfuTevF9I7M2eg7oUnc5f8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pyhA7EL+OD8RhQtkNkaHobID13Lpe6TtP08ksHTzaPQJ9xOMA+lDYNwdQTSQVigoG gwnyNlRvlB26f4S6XZusO3MvIaIeFUs2z5SydG6mF8SB20z4Y2UH6jxCopkVfGw6NI vgvh6AfwI2hAS19W4g4y+loayqSgGw7+R/4O1KY0= Date: Mon, 15 Apr 2019 10:48:44 +0200 From: Greg Kroah-Hartman To: Ronald =?iso-8859-1?Q?Tschal=E4r?= Cc: Jonathan Corbet , "Rafael J. Wysocki" , Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] debugfs: make return value of all debugfs helpers consistent Message-ID: <20190415084844.GA26101@kroah.com> References: <20190415082506.25610-1-ronald@innovation.ch> <20190415082506.25610-3-ronald@innovation.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190415082506.25610-3-ronald@innovation.ch> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Apr 15, 2019 at 01:25:06AM -0700, Ronald Tschalär wrote: > Since commit ff9fb72bc077 ("debugfs: return error values, not NULL") > almost all the debugfs helpers have stopped returning NULL. The lone > holdeout was debugfs_create_u32_array(). So fix that. > > Signed-off-by: Ronald Tschalär > --- > fs/debugfs/file.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c > index ddd708b09fa1..bb706d073782 100644 > --- a/fs/debugfs/file.c > +++ b/fs/debugfs/file.c > @@ -999,8 +999,8 @@ static const struct file_operations u32_array_fops = { > * Once array is created its size can not be changed. > * > * The function returns a pointer to dentry on success. If an error occurs, > - * %ERR_PTR(-ERROR) or NULL will be returned. If debugfs is not enabled in > - * the kernel, the value %ERR_PTR(-ENODEV) will be returned. > + * %ERR_PTR(-ERROR) will be returned. If debugfs is not enabled in the kernel, > + * the value %ERR_PTR(-ENODEV) will be returned. > */ > struct dentry *debugfs_create_u32_array(const char *name, umode_t mode, > struct dentry *parent, > @@ -1009,7 +1009,7 @@ struct dentry *debugfs_create_u32_array(const char *name, umode_t mode, > struct array_data *data = kmalloc(sizeof(*data), GFP_KERNEL); > > if (data == NULL) > - return NULL; > + return ERR_PTR(-ENOMEM); > > data->array = array; > data->elements = elements; There is only one caller of this function in the kernel now, and it does not even care about the return value at all, so we should just remove the return value entirely as that's the easiest and best thing to do here. I was going to start doing this slowly over time, but as you are touching the function now, might as well do it here :) thanks, greg k-h