From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 48B3D7D2F0 for ; Fri, 3 May 2019 06:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbfECGmo (ORCPT ); Fri, 3 May 2019 02:42:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:40822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbfECGmo (ORCPT ); Fri, 3 May 2019 02:42:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8DA92075E; Fri, 3 May 2019 06:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556865763; bh=eSwQ5MQqLLW9fJpp5z5L5wdOX/D46QfRbdkcz2wVbPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a8bRpPlYbJzGxvGVmp2uL9uXUULFTshM8QSJGuUzKTk19JZNQGVZMB/Y6WWZUO0Xk +Bv6ggtukUnBovktNVzoNapiH66e7QwUF2ou6Nv/zJgv58EYkE7vJAmpFpEvKEp4BX kligVpalV/krymcpGsId8WYpq006/flMnMSyr3rA= Date: Fri, 3 May 2019 08:42:41 +0200 From: Greg KH To: Brendan Higgins Cc: "Bird, Timothy" , Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , Amir Goldstein , Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, Iurii Zaikin Subject: Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Message-ID: <20190503064241.GC20723@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-17-brendanhiggins@google.com> <20190502110347.GE12416@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > -----Original Message----- > > > From: Greg KH > > > > > > On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins wrote: > > > > From: Iurii Zaikin > > > > > > > > KUnit tests for initialized data behavior of proc_dointvec that is > > > > explicitly checked in the code. Includes basic parsing tests including > > > > int min/max overflow. > > > > > > > > Signed-off-by: Iurii Zaikin > > > > Signed-off-by: Brendan Higgins > > > > --- > > > > kernel/Makefile | 2 + > > > > kernel/sysctl-test.c | 292 > > > +++++++++++++++++++++++++++++++++++++++++++ > > > > lib/Kconfig.debug | 6 + > > > > 3 files changed, 300 insertions(+) > > > > create mode 100644 kernel/sysctl-test.c > > > > > > > > diff --git a/kernel/Makefile b/kernel/Makefile > > > > index 6c57e78817dad..c81a8976b6a4b 100644 > > > > --- a/kernel/Makefile > > > > +++ b/kernel/Makefile > > > > @@ -112,6 +112,8 @@ obj-$(CONFIG_HAS_IOMEM) += iomem.o > > > > obj-$(CONFIG_ZONE_DEVICE) += memremap.o > > > > obj-$(CONFIG_RSEQ) += rseq.o > > > > > > > > +obj-$(CONFIG_SYSCTL_KUNIT_TEST) += sysctl-test.o > > > > > > You are going to have to have a "standard" naming scheme for test > > > modules, are you going to recommend "foo-test" over "test-foo"? If so, > > > that's fine, we should just be consistant and document it somewhere. > > > > > > Personally, I'd prefer "test-foo", but that's just me, naming is hard... > > > > My preference would be "test-foo" as well. Just my 2 cents. > > I definitely agree we should be consistent. My personal bias > (unsurprisingly) is "foo-test," but this is just because that is the > convention I am used to in other projects I have worked on. > > On an unbiased note, we are currently almost evenly split between the > two conventions with *slight* preference for "foo-test": I ran the two > following grep commands on v5.1-rc7: > > grep -Hrn --exclude-dir="build" -e "config [a-zA-Z_0-9]\+_TEST$" | wc -l > grep -Hrn --exclude-dir="build" -e "config TEST_[a-zA-Z_0-9]\+" | wc -l > > "foo-test" has 36 occurrences. > "test-foo" has 33 occurrences. > > The things I am more concerned about is how this would affect file > naming. If we have a unit test for foo.c, I think foo_test.c is more > consistent with our namespacing conventions. The other thing, is if we > already have a Kconfig symbol called FOO_TEST (or TEST_FOO) what > should we name the KUnit test in this case? FOO_UNIT_TEST? > FOO_KUNIT_TEST, like I did above? Ok, I can live with "foo-test", as you are right, in a directory listing and config option, it makes more sense to add it as a suffix. thanks, greg k-h