From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-13.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_DKIMWL_WL_MED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 91BD87D2EF for ; Wed, 29 May 2019 14:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbfE2OXf (ORCPT ); Wed, 29 May 2019 10:23:35 -0400 Received: from mail-qt1-f202.google.com ([209.85.160.202]:40869 "EHLO mail-qt1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbfE2OXf (ORCPT ); Wed, 29 May 2019 10:23:35 -0400 Received: by mail-qt1-f202.google.com with SMTP id 37so2070060qtc.7 for ; Wed, 29 May 2019 07:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=XGYstJC40WMJZKWA//5lX0DesV6Lf9IkKEWuIExOKfQ=; b=OxGkFghtWB+nfC8qcX2Kw1DsVLZiXrr3A8z8E+HRZvmT+P4PZgsM2i8FKDtVN7tDgH hgop1Onj22rDTO2gGCvdFKPSO5xNidsp747aLgC9xF4Ex/ixAp8jFbPx2QKZVN78N+hS Ggk2ZZ0W62WvE2E+pcwmicVuwiHwioEk+iAoq+K6OUsq+SBpoSwg9BkU8291Q3nF+9Vf SAWqxBrsaXEfWREmKwjcZzjQCB6CCmetGG45pyIdrG36kONp49A30PgdE3C+JilhISgE cHl3B8pFu2Eo8q7ybm2dJV9ScZ3Ulm+tHTyE4HopaiULoL+Vv8VhjnUZXjwpZLykZA2B p3NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=XGYstJC40WMJZKWA//5lX0DesV6Lf9IkKEWuIExOKfQ=; b=f7zK9gKkYiW1+GkHc92l87P6xsNmjMJb8UxlkOoWtNJNJHyS93S4cbe2ygOapD0f5d jY6K0x0XKZDp91XJquIIF1+nNxAwVo0uLkQU7mnvULsu3Y1Wt5rgL1jFATYf2WRKXaQ4 cQrKGzhYNM3zvwuas1yqSGBFDVq1IlhphXAsXMerlEeFHr+nrOOUmNw4Ta3Oqha5e7yq gwZ713WkSeVP9668w9IaImS+NCRxe1JEqj41jpIAFyuuDNPf8UCfYWFQgwJ2sLoy4W1/ QkzjUAPUvHKl1kCV6yOIAjExzQkvd+g8Ntq/tevxIm4BX4MdTp+AW2ztZVOqxZJugCMk KQrw== X-Gm-Message-State: APjAAAUE9r4q+yErvOsckzTldyn5epOLWMZr8Mx0sr4vbB72+Cz7Rywv F/VhJEyqAobAIF6ZoRcCJMgLbVFawg== X-Google-Smtp-Source: APXvYqyVy0u4kXUacxu4+JJYQdDdggxgHbmHU0olidJDRn2GT+1ov13CB+Sljlt1m7OrwthQ92dwHTjTPA== X-Received: by 2002:ac8:270b:: with SMTP id g11mr72071334qtg.363.1559139814057; Wed, 29 May 2019 07:23:34 -0700 (PDT) Date: Wed, 29 May 2019 16:14:59 +0200 In-Reply-To: <20190529141500.193390-1-elver@google.com> Message-Id: <20190529141500.193390-2-elver@google.com> Mime-Version: 1.0 References: <20190529141500.193390-1-elver@google.com> X-Mailer: git-send-email 2.22.0.rc1.257.g3120a18244-goog Subject: [PATCH v2 1/3] lib/test_kasan: Add bitops tests From: Marco Elver To: peterz@infradead.org, aryabinin@virtuozzo.com, dvyukov@google.com, glider@google.com, andreyknvl@google.com, mark.rutland@arm.com Cc: corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, Marco Elver Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org This adds bitops tests to the test_kasan module. In a follow-up patch, support for bitops instrumentation will be added. Signed-off-by: Marco Elver --- Changes in v2: * Use BITS_PER_LONG. * Use heap allocated memory for test, as newer compilers (correctly) warn on OOB stack access. --- lib/test_kasan.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 7de2702621dc..6562df0ca30d 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -11,16 +11,17 @@ #define pr_fmt(fmt) "kasan test: %s " fmt, __func__ +#include #include +#include #include -#include #include +#include +#include #include #include #include #include -#include -#include /* * Note: test functions are marked noinline so that their names appear in @@ -623,6 +624,73 @@ static noinline void __init kasan_strings(void) strnlen(ptr, 1); } +static noinline void __init kasan_bitops(void) +{ + long *bits = kmalloc(sizeof(long), GFP_KERNEL | __GFP_ZERO); + if (!bits) + return; + + pr_info("within-bounds in set_bit"); + set_bit(0, bits); + + pr_info("within-bounds in set_bit"); + set_bit(BITS_PER_LONG - 1, bits); + + pr_info("out-of-bounds in set_bit\n"); + set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __set_bit\n"); + __set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in clear_bit\n"); + clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __clear_bit\n"); + __clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in clear_bit_unlock\n"); + clear_bit_unlock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __clear_bit_unlock\n"); + __clear_bit_unlock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in change_bit\n"); + change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __change_bit\n"); + __change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_set_bit\n"); + test_and_set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_set_bit\n"); + __test_and_set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_set_bit_lock\n"); + test_and_set_bit_lock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_clear_bit\n"); + test_and_clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_clear_bit\n"); + __test_and_clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_change_bit\n"); + test_and_change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_change_bit\n"); + __test_and_change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_bit\n"); + (void)test_bit(BITS_PER_LONG, bits); + +#if defined(clear_bit_unlock_is_negative_byte) + pr_info("out-of-bounds in clear_bit_unlock_is_negative_byte\n"); + clear_bit_unlock_is_negative_byte(BITS_PER_LONG, bits); +#endif + kfree(bits); +} + static int __init kmalloc_tests_init(void) { /* @@ -664,6 +732,7 @@ static int __init kmalloc_tests_init(void) kasan_memchr(); kasan_memcmp(); kasan_strings(); + kasan_bitops(); kasan_restore_multi_shot(multishot); -- 2.22.0.rc1.257.g3120a18244-goog