From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-13.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_DKIMWL_WL_MED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id C34257D910 for ; Fri, 31 May 2019 15:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfEaPLk (ORCPT ); Fri, 31 May 2019 11:11:40 -0400 Received: from mail-yb1-f201.google.com ([209.85.219.201]:49895 "EHLO mail-yb1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfEaPLj (ORCPT ); Fri, 31 May 2019 11:11:39 -0400 Received: by mail-yb1-f201.google.com with SMTP id d6so7639991ybj.16 for ; Fri, 31 May 2019 08:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=gLta7Etz+AT0uZJXEtTw/d9Eqbqeoj2w6clUtWu9Mu8=; b=Rjf39fVreMPfvvAWdL8HT5/mVr9xbaBS39GnzTO7+6MCC0JLLliFuf45FzHxsuMf/s L4GVVlmofl8BIzqyEmHmh+i5EKD/M8mhGsWFx1arfIivAjyT2hKxo5ShJzgfiGH//v39 WcH19jlZSZ93VxzQdGev9phccKTA8RhPeZW60okoDlAJs2WGZdfXrEgitKIl2e0Rnyua jFEMeBpQI2iXQrNqGmW3m+rHvpmPKJCjR9Za5pHvFm60T3M/pDOV3DMOKv3hfEBchsgH PJxZ7xs49yQsHBMa1Cw7DmgDFuGsAppiL6hkU4pznIdKVCT1z1TsgjSA0EQo93oPO+gj AizA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=gLta7Etz+AT0uZJXEtTw/d9Eqbqeoj2w6clUtWu9Mu8=; b=FbD6wdqilxtnnh+4hSImu2RFvWzKgsmdE9D9ot/u3F95/tlwwUZTCDaG8o12UBcUHg nKW5uWzjSQ8IzBxbjudkjPQcF8Ak4Qg+ONHgnQpp44ayKoVgjRAN5b9i0TMeNoTxzdSn 8qk8+M4Zyc6VyZjhq1pc5iCosde2KF1/bnyVrtOMFLqeXJvdbXK07xp4mhgupJDP2XWP BUCixCivuMM4QEN8wk5119bDB5l+S6URCG0S3ILta3GLVhd7DdoZE1O1P/V9WqVWYvvc t8W4WefNFIC+4W2JpW5qnSocmmpc19sv0/JrvEZmIKKP5PyGeOGC+VBjtS7gwoxfpIgk HHDw== X-Gm-Message-State: APjAAAXLw+0Z8vGFR++KzQ1PNfH5DIPPTo+PpVvFTCcahhWix4ijxgSs TuhxDRtup4A0flTmaAWl1DIVsS+LxA== X-Google-Smtp-Source: APXvYqyD9dFfj0smZxXNxXzPioh7Dykim0ewD5FKJbw91RkUv2vU0UgdGRx1UmdnPlXwFR4hNKFTPT+iTQ== X-Received: by 2002:a81:980b:: with SMTP id p11mr5711332ywg.48.1559315498458; Fri, 31 May 2019 08:11:38 -0700 (PDT) Date: Fri, 31 May 2019 17:08:29 +0200 In-Reply-To: <20190531150828.157832-1-elver@google.com> Message-Id: <20190531150828.157832-2-elver@google.com> Mime-Version: 1.0 References: <20190531150828.157832-1-elver@google.com> X-Mailer: git-send-email 2.22.0.rc1.257.g3120a18244-goog Subject: [PATCH v3 1/3] lib/test_kasan: Add bitops tests From: Marco Elver To: peterz@infradead.org, aryabinin@virtuozzo.com, dvyukov@google.com, glider@google.com, andreyknvl@google.com, mark.rutland@arm.com, hpa@zytor.com Cc: corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, Marco Elver Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org This adds bitops tests to the test_kasan module. In a follow-up patch, support for bitops instrumentation will be added. Signed-off-by: Marco Elver --- Changes in v3: * Use kzalloc instead of kmalloc. * Use sizeof(*bits). Changes in v2: * Use BITS_PER_LONG. * Use heap allocated memory for test, as newer compilers (correctly) warn on OOB stack access. --- lib/test_kasan.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 7de2702621dc..1ef9702327d2 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -11,16 +11,17 @@ #define pr_fmt(fmt) "kasan test: %s " fmt, __func__ +#include #include +#include #include -#include #include +#include +#include #include #include #include #include -#include -#include /* * Note: test functions are marked noinline so that their names appear in @@ -623,6 +624,73 @@ static noinline void __init kasan_strings(void) strnlen(ptr, 1); } +static noinline void __init kasan_bitops(void) +{ + long *bits = kzalloc(sizeof(*bits), GFP_KERNEL); + if (!bits) + return; + + pr_info("within-bounds in set_bit"); + set_bit(0, bits); + + pr_info("within-bounds in set_bit"); + set_bit(BITS_PER_LONG - 1, bits); + + pr_info("out-of-bounds in set_bit\n"); + set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __set_bit\n"); + __set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in clear_bit\n"); + clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __clear_bit\n"); + __clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in clear_bit_unlock\n"); + clear_bit_unlock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __clear_bit_unlock\n"); + __clear_bit_unlock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in change_bit\n"); + change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __change_bit\n"); + __change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_set_bit\n"); + test_and_set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_set_bit\n"); + __test_and_set_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_set_bit_lock\n"); + test_and_set_bit_lock(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_clear_bit\n"); + test_and_clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_clear_bit\n"); + __test_and_clear_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_and_change_bit\n"); + test_and_change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in __test_and_change_bit\n"); + __test_and_change_bit(BITS_PER_LONG, bits); + + pr_info("out-of-bounds in test_bit\n"); + (void)test_bit(BITS_PER_LONG, bits); + +#if defined(clear_bit_unlock_is_negative_byte) + pr_info("out-of-bounds in clear_bit_unlock_is_negative_byte\n"); + clear_bit_unlock_is_negative_byte(BITS_PER_LONG, bits); +#endif + kfree(bits); +} + static int __init kmalloc_tests_init(void) { /* @@ -664,6 +732,7 @@ static int __init kmalloc_tests_init(void) kasan_memchr(); kasan_memcmp(); kasan_strings(); + kasan_bitops(); kasan_restore_multi_shot(multishot); -- 2.22.0.rc1.257.g3120a18244-goog