linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/9] hrtimer: Use a bullet for the returns bullet list
Date: Fri, 28 Jun 2019 10:03:05 -0300	[thread overview]
Message-ID: <20190628100305.4c5729fd@coco.lan> (raw)
In-Reply-To: <951e47de7dd6d86516c25ceb855c4b64f13fb65d.camel@perches.com>

Em Fri, 28 Jun 2019 05:39:25 -0700
Joe Perches <joe@perches.com> escreveu:

> On Fri, 2019-06-28 at 09:12 -0300, Mauro Carvalho Chehab wrote:
> > That gets rid of this warning:
> > 
> > 	./kernel/time/hrtimer.c:1119: WARNING: Block quote ends without a blank line; unexpected unindent.
> > 
> > and displays nicely both at the source code and at the produced
> > documentation.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> >  kernel/time/hrtimer.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> > index edb230aba3d1..5ee77f1a8a92 100644
> > --- a/kernel/time/hrtimer.c
> > +++ b/kernel/time/hrtimer.c
> > @@ -1114,9 +1114,10 @@ EXPORT_SYMBOL_GPL(hrtimer_start_range_ns);
> >   * @timer:	hrtimer to stop
> >   *
> >   * Returns:
> > - *  0 when the timer was not active
> > - *  1 when the timer was active
> > - * -1 when the timer is currently executing the callback function and
> > + *
> > + *  *  0 when the timer was not active
> > + *  *  1 when the timer was active
> > + *  * -1 when the timer is currently executing the callback function and
> >   *    cannot be stopped  
> 
> I think this last line should be indented 3 more spaces too

That would produce a warning, and will change the font for the content of 
the first line to bold. 

ReST is pedantic with whitespaces, as it uses it to identify continuation
lines.

For it to consider one line as a continuation of the previous one, the texts
on both lines (after markups) should start at the same place.

So, on:

	* foo
	  bar

"bar" is considered a continuation of the first line. So, identical to:

	* foo bar

But:

	* foo bar
	      foobar

the whitespace doesn't match. it will change the font for the first line
to bold, and place foobar on a separate line.


(yeah, I know that, for kernel-doc, this sucks)


Thanks,
Mauro

  reply	other threads:[~2019-06-28 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 12:12 [PATCH 0/9] Some doc fixes Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 1/9] hrtimer: Use a bullet for the returns bullet list Mauro Carvalho Chehab
2019-06-28 12:39   ` Joe Perches
2019-06-28 13:03     ` Mauro Carvalho Chehab [this message]
2019-06-28 12:12 ` [PATCH 2/9] docs: trace: fix a broken label Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 3/9] docs: signal: fix a kernel-doc markup Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 4/9] dt: leds-lm36274.txt: fix a broken reference to ti-lmu.txt Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 5/9] docs: fix some broken references due to txt->rst renames Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 6/9] docs: virtual: there are two orphan docs there Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 7/9] docs: gpu: add msm-crash-dump.rst to the index.rst file Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 8/9] drm: fix a reference for a renamed file: fb/modedb.rst Mauro Carvalho Chehab
2019-06-28 12:12 ` [PATCH 9/9] platform: x86: get rid of a non-existent document Mauro Carvalho Chehab
2019-06-28 14:49   ` Andy Shevchenko
2019-06-28 15:01     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628100305.4c5729fd@coco.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=corbet@lwn.net \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).